Bug 90295 - ASTRewriteAnalyzer#doTextCopy(..) adds edit twice to group
Summary: ASTRewriteAnalyzer#doTextCopy(..) adds edit twice to group
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.1 M7   Edit
Assignee: Martin Aeschlimann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-05 10:09 EDT by Markus Keller CLA
Modified: 2005-05-11 12:22 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2005-04-05 10:09:26 EDT 
I20050401-1645

ASTRewriteAnalyzer#doTextCopy(..) contains code:
		if (editGroup != null) {
			addEditGroup(editGroup, targetEdit);
			addEditGroup(editGroup, targetEdit);
		}

I'd say it's sufficient to add the edit just once to the group. I found this
while debugging something else. I guess the two calls are just redundant, since
it doesn't cause any visible harm and things still work when I delete the second
call.
Comment 1 Markus Keller CLA 2005-04-06 10:59:15 EDT 
Bug 89524 revealed that the first call should be:

			addEditGroup(editGroup, sourceEdit);
Comment 2 Martin Aeschlimann CLA 2005-04-13 13:05:21 EDT 
fixed in 20050412
Comment 3 Martin Aeschlimann CLA 2005-04-13 13:06:33 EDT 
really fixed (wrong bugzilla radio button selected..)
Comment 4 Martin Aeschlimann CLA 2005-05-11 12:22:36 EDT 
verified in 20050509-2010