Bug 89793 - Excluding a file with warnings does not clear warnings in incremental mode
Summary: Excluding a file with warnings does not clear warnings in incremental mode
Status: RESOLVED FIXED
Alias: None
Product: AJDT
Classification: Tools
Component: Core (show other bugs)
Version: 1.2.0 M2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.2.0 RC1   Edit
Assignee: Sian January CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-31 04:52 EST by Matthew Webster CLA
Modified: 2005-05-06 09:23 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Webster CLA 2005-03-31 04:52:32 EST
Actual dev build: 1.2.0.20050321

If I have a file which is causing warnings (markers in editor, annotations in 
Package Explorer and entry in Problems view) I exclude it using the context 
menu in the Package explorer. The project is rebuilt and the markers disappear 
from the editor but the problem remains. The message is only cleared with a 
full rebuild.
Comment 1 Matt Chapman CLA 2005-03-31 07:41:51 EST
Sian,
Could you take a quick look? We could either try to handle this by removing
markers from excluded files, or if need be force a full build. Presumably the
case of including files is okay with incremental.
Comment 2 Sian January CLA 2005-04-07 05:53:23 EDT
This looks to be an AspectJ compiler bug, where if a file is no longer 
included in the build the compiler doesn't clear the associated problems.  
Transferring the bug to AspectJ
Comment 3 Andrew Clement CLA 2005-04-07 05:59:34 EDT
Poss related to the work I did previously to remove 'duplicate' warnings
appearing after each incremental compile - I don't remember making that code
aware of which files were removed from a particular build?
Comment 4 Helen Beeken CLA 2005-04-07 08:37:50 EDT
I think this is an AJDT bug which I've just fixed:

BUILD COMPLETE -  build.272
Date of build: 04/07/2005 11:56:44
Time to build: 30 minutes 25 seconds
Last changed: 04/07/2005 11:42:57
Last log entry: calling preCallListeners(..) with updated build kind, otherwise
the preprocessing could be done for the wrong type of build (a consequence being
markers are sometimes not cleared)


The build(..) method is called in AJBuilder with a build kind. What we were
doing was first calling any listeners to do some preproccessing (in the case of
the ui, then this is where markers are cleared) and then on returning from this
we checked whether in fact a full build has been requested regardless of the
initial build kind. When changes are made to the build configurations this
returns true. So what was happening was that the preproccessing was being called
assuming there was going to be an incremental build (and consequently didn't
recursively remove any markers) and then a full build was occurring. Swiching
these two calls around so that we do any preproccessing with the updated build
kind fixes this problem.
Comment 5 Helen Beeken CLA 2005-04-08 08:21:57 EDT
We've confirmed that this is fixed in AJDT 1.2.0.200504071428 (our M3
candidate). There is, however, one remaining issue, in that if the file
containing the warning/error is open in the editor, then the editor marker isn't
cleared. Can you please transfer this to the AJDT bug queue.

Thanks, Helen
Comment 6 Sian January CLA 2005-05-06 09:23:22 EDT
Fixed the final remaining issue