Bug 89474 - [polish] Installed JRE pref page: Modify multiple attributes at once
Summary: [polish] Installed JRE pref page: Modify multiple attributes at once
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC1   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
: 92804 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-03-30 03:59 EST by Martin Aeschlimann CLA
Modified: 2006-04-04 13:56 EDT (History)
3 users (show)

See Also:


Attachments
Removes Edit button, adds two new buttons (8.95 KB, patch)
2005-11-28 16:06 EST, Gary Barbon CLA
no flags Details | Diff
Removes Edit button, adds two new buttons (8.95 KB, patch)
2005-11-28 16:06 EST, Gary Barbon CLA
no flags Details | Diff
working patch (13.20 KB, patch)
2006-03-21 13:00 EST, Michael Rennie CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2005-03-30 03:59:17 EST
20050330

On the installed JRE pref page, it should be possible to set all the source
attachment and Javadoc locations at once as they are typically the same.
I suggest to allow multiple selection. As it is a lot of work to expand all
nodes and select all the 'source attachment' an idea could be to replace the
'edit' button with a 'source attachment' and a 'javadoc location' button that
are enabled also on the entries (and support multiple selection)
Comment 1 Darin Wright CLA 2005-04-18 16:02:38 EDT
Deferred
Comment 2 Darin Wright CLA 2005-05-26 14:35:13 EDT
*** Bug 92804 has been marked as a duplicate of this bug. ***
Comment 3 Stephen Schaub CLA 2005-05-27 09:24:52 EDT
In versions of Eclipse up to 3.1M5a, there used to be an input box for setting 
Javadoc URL for the installed JRE (Preferences/Java). In 3.1M6, this input box
was removed. Why was it removed? It's important for many users to be able to
associate local javadoc with an installed JRE. Please bring it back for the 3.1
release.
Comment 4 Darin Wright CLA 2005-05-27 09:32:04 EDT
The field was removed to allow a different javadoc location to be set for 
individual jars in the JRE. The buildpath allowed it, but the JRE did not 
which caused an inconsistency and issues with persisting restoring.

I agree we should have a way to set a "global" javadoc location for a JRE's 
archives, or a way to multi-select and set the value. This may not happen in 
3.1 due to time constraints/priorities in remaining cycles.

I'll re-open the bug such that it gets considered.
Comment 5 Markus Keller CLA 2005-05-27 11:32:08 EDT
Note that you can select multiple "Javadoc location" nodes and edit them at
once. However, I agree that the typical user needs too many clicks now.
Comment 6 Darin Wright CLA 2005-05-27 11:57:33 EDT
Thanks Markus, I did not know that multi-selection worked. Somewhat of a 
workaround.
Comment 7 Darin Wright CLA 2005-06-03 09:08:45 EDT
Work around will have to suffice for 3.1. Will re-address in 3.2.
Comment 8 Gunnar Wagenknecht CLA 2005-07-01 03:00:57 EDT
I think this is a good 3.1.1 candidate. Currently the preference dialog isn't in
synch either. See bug 102446.
Comment 9 Darin Wright CLA 2005-07-05 10:10:29 EDT
Generally, we restrict incremental releases to critical bug fixes, rather than 
feature improvements/enhancments. Will consider for 3.2.
Comment 10 Gary Barbon CLA 2005-11-28 16:06:45 EST
Created attachment 30727 [details]
Removes Edit button, adds two new buttons

This patch follows the suggestion in Comment #1, by removing the edit button, and replacing it with two new buttons which allow the editing of Javadoc location or Source Attachment location with regards to multiple library selection.
Comment 11 Gary Barbon CLA 2005-11-28 16:06:54 EST
Created attachment 30728 [details]
Removes Edit button, adds two new buttons

This patch follows the suggestion in Comment #1, by removing the edit button, and replacing it with two new buttons which allow the editing of Javadoc location or Source Attachment location with regards to multiple library selection.
Comment 12 Gary Barbon CLA 2005-11-29 15:10:39 EST
Assigning to Darin for review.
Comment 13 Michael Rennie CLA 2006-03-21 13:00:08 EST
Created attachment 36675 [details]
working patch

recoded the patch, supports multi selection of all elements
Comment 14 Michael Rennie CLA 2006-03-21 13:02:29 EST
Please verify Darin W
Comment 15 Darin Wright CLA 2006-04-04 13:53:58 EDT
Applied patch with minor changes (NLS strings).
Comment 16 Darin Wright CLA 2006-04-04 13:56:49 EDT
Verified.