Bug 89096 - Convert to new platform NLS support
Summary: Convert to new platform NLS support
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 M7   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
: 45486 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-03-25 08:04 EST by Jerome Lanneluc CLA
Modified: 2005-05-13 09:17 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2005-03-25 08:04:39 EST 
I20050324

Message from John Arthorne on eclipse-dev:

Eclipse 3.1 M5 has introduced a new resource bundle mechanism that is
significantly more efficient than the standard Java property resource bundle
mechanism.  This new mechanism stores each messages as a static field whose
value is bound at runtime based on the current locale.  The result is that
message keys are no longer stored in memory as strings, and the overhead of the
Hashtable used by property resource bundle is eliminated.  More details on the
new API, along with analysis of its performance and a conversion tool for those
using property resource bundles, is found here: 

http://dev.eclipse.org/viewcvs/index.cgi/%7Echeckout%7E/platform-core-home/documents/3.1/message_bundles.html
Comment 1 Philipe Mulet CLA 2005-04-07 09:27:15 EDT 
*** Bug 45486 has been marked as a duplicate of this bug. ***
Comment 2 Philipe Mulet CLA 2005-04-07 18:15:10 EDT 
Remember to not introduce any dependency on Eclipse layer from within batch
compiler.
Comment 3 Olivier Thomann CLA 2005-04-08 16:41:06 EDT 
Converted messages from the Model. All tests passed. I reuse the
java.text.MessageFormat instead of the bind method from the NLS class. So I can
get rid of the dependency on bug 90803.
Comment 4 Olivier Thomann CLA 2005-04-11 11:42:20 EDT 
Fixed and released in HEAD.
org.eclipse.jdt.internal.compiler.util.messages.properties and
org.eclipse.jdt.internal.core.util.messages.properties have been converted.
Comment 5 Maxime Daniel CLA 2005-05-12 13:34:59 EDT 
Verified for 3.1 M7 using build I20050509-2010 + jdt.core HEAD-20050512.