Bug 89094 - [performance] DOM AST conversion could intern String locally
Summary: [performance] DOM AST conversion could intern String locally
Status: RESOLVED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-Core-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2005-03-25 07:42 EST by Philipe Mulet CLA
Modified: 2009-08-30 02:12 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipe Mulet CLA 2005-03-25 07:42:36 EST
Build 3.1m5a

When converting AST, DOM is allocating a String for every token. Given these may
be shared by underlying Scanner, the DOM representation is wasting memory there.
It could do some String interning (at least per DOM AST pipeline basis).
Comment 1 Philipe Mulet CLA 2005-04-05 15:40:49 EDT
You may want to interact with Jerome to see if you could reuse some of the model
infrastructure.
In your case, you want to query existing Strings based on a char[] (equals). The
model has sets of char[] and String to avoid persisting more than one instance
of each, could be something which could be augmented for DOM AST support (and
maybe model could start using it as well).
Comment 2 Olivier Thomann CLA 2005-05-10 08:00:21 EDT
Close as LATER
Comment 3 Denis Roy CLA 2009-08-30 02:12:40 EDT
As of now 'LATER' and 'REMIND' resolutions are no longer supported.
Please reopen this bug if it is still valid for you.