Bug 87845 - [1.5][dom][javadoc] allow javadoc references to vararg methods
Summary: [1.5][dom][javadoc] allow javadoc references to vararg methods
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.1 M6   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-11 18:35 EST by Jim des Rivieres CLA
Modified: 2005-03-30 16:39 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jim des Rivieres CLA 2005-03-11 18:35:36 EST 
MethodRefParameter nodes should support variable arity references
like "#foo(String...)" and "#foo(String... args)".

This problem is a follow-on from bug 83393.

The 1.5 spec for the Javadoc tool does not mention the possibility
of a variable arity indicator in method references. However, the 1.5
Javadoc tool itself does indeed support it. Since it makes sense to have
a way to explicitly refer to variable arity methods, it seems more likely
that the Javadoc spec is wrong in this case.
Comment 1 Jim des Rivieres CLA 2005-03-11 18:47:23 EST 
Added API to MethodRefParameter:
 public static final SimplePropertyDescriptor VARARGS_PROPERTY;
 public boolean isVarargs();
 public void setVarargs(boolean variableArity);

I've released changes to specs, basic node implementation, and basic tests.
Parts that also require changing:
- AST parser and binding resolver
- AST rewriter
- downstream clones of NaiveASTFlatterner
Comment 2 Frederic Fusier CLA 2005-03-13 14:08:32 EST 
I'll do AST parser and binding resolver changes
Comment 3 Martin Aeschlimann CLA 2005-03-14 07:08:04 EST 
added support to rewriter > 20050314
Comment 4 Frederic Fusier CLA 2005-03-14 13:22:18 EST 
Done for AST parser (changes done in ASTConverter) and binding resolver (no
change was requested for this new API).

[jdt-core-internal]
Test case added in ASTConverterJavadocTest.
Comment 5 Markus Keller CLA 2005-03-17 06:18:34 EST 
Added support to jdt.ui's ASTFlattener.
Comment 6 Olivier Thomann CLA 2005-03-30 16:39:07 EST 
Verified in I20050330-0500