Bug 87644 - Control access rules severity
Summary: Control access rules severity
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 M6   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-10 09:39 EST by Jerome Lanneluc CLA
Modified: 2005-03-31 06:02 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2005-03-10 09:39:43 EST 
I20050308

To be consistent with the runtime behavior where you can have strict and loose
access control to classes in required plugin, PDE needs to control the severity
of access rules. Some access rules would always be flagged as errors, some would
be flagged as warnings.
Comment 1 Jerome Lanneluc CLA 2005-03-21 17:49:03 EST 
Added the following APIs to control access rules severity:
- IAccessRule
    int K_ACCESSIBLE;
    int K_NON_ACCESSIBLE;
    int K_DISCOURAGED;
    IPath getPattern();
    int getKind();
- JavaCore
    String COMPILER_PB_DISCOURAGED_REFERENCE;
    IAccessRule newAccessRule(IPath pattern, int kind);
    IClasspathEntry newContainerEntry(
			IPath containerPath, 
			IAccessRule[] accessRules, 
			IClasspathAttribute[] extraAttributes,
			boolean isExported);
    IClasspathEntry newLibraryEntry(
			IPath path,
			IPath sourceAttachmentPath,
			IPath sourceAttachmentRootPath,
			IAccessRule[] accessRules, 
			IClasspathAttribute[] extraAttributes,
			boolean isExported);
    IClasspathEntry newProjectEntry(
			IPath path, 
			IAccessRule[] accessRules, 
			boolean combineAccessRules,
			IClasspathAttribute[] extraAttributes,
			boolean isExported);
    IClasspathEntry newVariableEntry(
			IPath variablePath,
			IPath variableSourceAttachmentPath,
			IPath variableSourceAttachmentRootPath,
			IAccessRule[] accessRules, 
			IClasspathAttribute[] extraAttributes,
			boolean isExported);
- IClasspathEntry
    boolean combineAccessRules();
    IAccessRule[] getAccessRules();
Comment 2 Wassim Melhem CLA 2005-03-21 17:51:39 EST 
Jerome, any chance the discouraged types are not in the code assist 
proposals?  or is that a separate issue?
Comment 3 Wassim Melhem CLA 2005-03-21 17:52:21 EST 
by discouraged, I also meant inaccessible ;-)
Comment 4 Jerome Lanneluc CLA 2005-03-21 17:53:24 EST 
That's a separate issue. David is adding flags to control this.
Comment 5 David Audel CLA 2005-03-31 06:02:06 EST 
Verified in I20050330-0500