Bug 87549 - [Manifest Editor] Editor remains dirty after save
Summary: [Manifest Editor] Editor remains dirty after save
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Mike Pawlowski CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
: 90097 93978 107701 165462 173054 175371 180108 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-03-09 14:29 EST by DJ Houghton CLA
Modified: 2007-04-10 17:41 EDT (History)
8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2005-03-09 14:29:56 EST 
build 3.0.1 RC2

- create new plug-in project
- check "create OSGi manifest file
- hit OK
- plug-in manifest editor opens
- click on the "Build Configuration" link in the Deploying section of the
Overview page
- check the Custom Build checkbox
- note that the editor is dirty
- uncheck the checkbox
- note that the editor is still dirty
- go to the Runtime page
- select the radio for "Do not activate this plug-in"
- note the editor is dirty

Now hit Ctrl+S to save.

Note that nothing happens. The editor remains dirty and if you try and close it,
it prompts you to save.

Nothing in my log file.
Comment 1 DJ Houghton CLA 2005-03-09 14:33:59 EST 
File -> Save doesn't work either.
Comment 2 Wassim Melhem CLA 2005-03-09 20:33:12 EST 
the problem exists in 3.0, 3.0.x and still in 3.1.

It is very specific to a scenario where we make the build editor dirty (check 
the checkbox) and then reverse it (uncheck it), ie. when we have a pending 
text operation in the build editor that is removed.

Considering the rarity of this scenario and the fact that saving is possible 
when the red x is clicked, it is not critical for 3.0.2.
We are dealing with a very sensitive area in the editor code here.
Comment 3 Wassim Melhem CLA 2005-04-02 20:42:51 EST 
*** Bug 90097 has been marked as a duplicate of this bug. ***
Comment 4 Wassim Melhem CLA 2005-05-26 00:50:46 EDT 
*** Bug 93978 has been marked as a duplicate of this bug. ***
Comment 5 Wassim Melhem CLA 2005-08-23 05:42:12 EDT 
*** Bug 107701 has been marked as a duplicate of this bug. ***
Comment 6 Simon Archer CLA 2006-06-17 16:05:14 EDT 
Can this be considered for 3.3?
Comment 7 Brian Bauman CLA 2006-11-22 15:11:54 EST 
*** Bug 165462 has been marked as a duplicate of this bug. ***
Comment 8 Wassim Melhem CLA 2007-02-23 23:20:06 EST 
*** Bug 175371 has been marked as a duplicate of this bug. ***
Comment 9 Brian Bauman CLA 2007-03-30 14:34:26 EDT 
*** Bug 180108 has been marked as a duplicate of this bug. ***
Comment 10 Wassim Melhem CLA 2007-04-09 02:44:16 EDT 
*** Bug 173054 has been marked as a duplicate of this bug. ***
Comment 11 Wassim Melhem CLA 2007-04-09 02:46:55 EDT 
Mike, can you please address this one as we kick off Manifest Editor Theme Week (April 10-13)?
Comment 12 Mike Pawlowski CLA 2007-04-10 14:37:28 EDT 
Fixed. Patch released to HEAD.

Target:  3.3 M7
Patch:   patch_87549_2007-04-10_14-13.txt

The problem was that various user editor actions yielded text edit operations 
that cancelled each other out.  This prevented the need to flush the underlying 
plug-in XML files input context and correctly clear the editor's dirty state; 
since, the model was already synchronized.

Verified this fix using all the different scenarios listed in this bug report
as duplicates.  Also verified this fix for a great number of other 
scenarios that could easily put the editor in a perpetual dirty state due to
this bug.
Comment 13 Wassim Melhem CLA 2007-04-10 17:41:55 EDT 
Thanks Mike.  A great way to kick off Manifest Editor Theme week.