Community
Participate
Working Groups
Undo add port wipes out graph view - all components disappear, and all that is left are the categories
Here are the results of my investigation. There are a few things interacting to cause this bug. First, the AddPortAction is not playing nice with the undo/redo mechanism (there may be other actions like this). Unlike other actions, it does not extend AddElementAction, and thus does not call the beginRecording()/endRecording() methods on the underlying model. This causes only partial undos, for example instead of undoing the text for the entire port, it would only undo the last action which was adding the port name attribute. Once this was out of the way, the original problem was still there. I traced the cause as follows: - the user selects undo - the underlying editor's undo manager undoes the action by basically removing all the equivalent text changes made when the port was added through the graphical view. - the text editor notifies the associated DOM model that a text change is taking place - the DOMModel locates and removes the associated element - when the element is removed, the parentNode is set to null, basically detaching the node from its parent - the model then notifies its listeners, among which is the WSDLModelReconcileAdapter - the adapter attempts to syncronize the WSDL model with the DOMModel - the first change done is to reconcile the WSDLPort object attributes with the underlying DOM model (basically removing it, since we are undoing) - the code in WSDLEditorUtil.getInstance().findModelObjectForElement tries to get the PortImpl object based on the underlying Element - this code fails because of the lack of a way of finding the path to the root (remember the parentNode is already null) and returns the root DocumentImpl instead!!! - so instead of removing the contents of the PortImpl, the code instead calls DefinitionImpl#handleReconciliation which effectively blows away the entire definition content - hence, the dissapearing content in the graphical view. The text view still has the service element, so it is out of synch with the graphical view and the internal wsdl model. I believe this is the end of mistery... Now a fix for this is a totally different issue :-)
Although bug 86551 makes it difficult to re-test this bug... I can flip to the source view and use undo/redo there. When I try this it seems like I can undo a 'add port' and all is well. Valentin, is this problem magically fixed?
The way the editor is notified of DOM events seems to have changed, probably as a result of it manipulating the WSDL model directly and not the DOM as we used to. The order of events appears to have changed: the attribute node removal is processed while the parent port node still has a parent. Thus I cannot seem to be able to reproduce the original problem. I propose we close for 1.5.
See previous comment.
To undo an add port (with binding and soap protocol), the current behaviour is now to run 5 undo text actions and 1 undo add. Was the compound command removed? The graph view doesn't get wiped out.
Will open a separate bug for the compound command.
Closing bug
