Bug 85946 - NamingConventions.suggestFieldNames(..) does not consider 'final' modifier for constants
Summary: NamingConventions.suggestFieldNames(..) does not consider 'final' modifier fo...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M3   Edit
Assignee: David Audel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 99683
  Show dependency tree
 
Reported: 2005-02-21 05:42 EST by Markus Keller CLA
Modified: 2008-10-27 07:42 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2005-02-21 05:42:38 EST 
I20050218-1600

NamingConventions.suggestFieldNames(..) does not consider the 'final' modifier
for constants. E.g. when asked:

NamingConventions.suggestFieldNames(
  project, "", "ArrayList", 0, Flags.AccStatic | Flags.AccFinal, new String[0]);

..., the answer is {"list", "arrayList"}.
Expected: {"LIST", "ARRAY_LIST"}
Comment 1 Markus Keller CLA 2005-06-14 03:58:20 EDT 
If we want the full flexibility here, then you should introduce new
prefix/suffix options for constants (static final fields). But IMO, it would be
sufficient to just use no prefix/suffix at all for constants.
Comment 2 David Audel CLA 2006-03-30 06:17:36 EST 
Deferred post 3.2
Comment 3 Markus Keller CLA 2006-06-08 11:48:58 EDT 
Could this bug please be considered for 3.3? It would be quite hard for us to work around this -- we would basically have to duplicate most of org.eclipse.jdt.internal.core.InternalNamingConventions.suggestNames(..).
Comment 4 Philipe Mulet CLA 2007-08-31 12:19:04 EDT 
considering for 3.4
Comment 5 Jerome Lanneluc CLA 2008-02-13 12:04:39 EST 
Time permitting for 3.4
Comment 6 Jerome Lanneluc CLA 2008-05-12 05:24:44 EDT 
Deferring post 3.4
Comment 7 Jerome Lanneluc CLA 2008-09-11 10:20:24 EDT 
Targeting M3
Comment 8 David Audel CLA 2008-10-22 07:47:12 EDT 
Released for 3.5M3.

This bug is fixed by the fix for bug 38111
Comment 9 Jerome Lanneluc CLA 2008-10-27 07:42:53 EDT 
Verified for 3.5M3 using I20081026-2000