Community
Participate
Working Groups
build I20050209 The RCP templates should be fixed up to use the refactored advisors (see bug 83658).
Created attachment 17848 [details] Fixed up Sample Application Created a Sample Application default RCP plugin, then refactored it. Only the advisor classes are affected.
Now working on the mail template. Next time I won't include the .class files in the zip.
The super send in preWindowOpen isn't actually needed -- the default implementation is spec'ed to do nothing.
thanks Nick. I made the changes to the basic template and actually moved it to the templates page. Anxiously awaiting part 2 of the patch <g>.
*** Bug 85149 has been marked as a duplicate of this bug. ***
Created attachment 17928 [details] Fixed up sample mail application (zip) This has quite a few other changes besides the advisor refactoring: simplified viewer, various type renamings, some other code cleanup. It would be nice if this could make it in for M5.
Doh. I included the .class files again.
thanks Nick. Now it certainly can make it into M5. We now keep 2 copies of each RCP template. One to be generated against a 3.0 target platform where those new classes were not invented. One to be generated against 3.1 because the 3.0 template results in deprecated code.
I forgot to ask, is there anything that documents the API changes themselves?
All done. thanks Nick.
Wassim, if the non-advisor changes could be put into the 3.0 template, that would be good. In particular, the viewer changes in NavigatorView (and its renaming). Also, for the image handling it's best to use the AbstractUIPlugin method rather than Bundle.find. Ed, the only documentation for the API changes is the Javadoc. If you'd like me to fix up the tutorial examples, I can do so.
Actually, bug 83658 describes the API change. Sorry Ed, I meant to cc you on this.
already did all of that.
Nick, I never turn down an offer to do work so feel free, but only if you change the tutorial text to match it. If you don't have time for that, that's ok because they'll continue to work due to the compatability layer you put in.
I probably won't have the chance to fix up the tutorials for M5, but I would like to see them changed to use the new advisor structure. It really does lead to a cleaner factoring.
