Bug 83890 - incremental: only do a full build if pointcuts change
Summary: incremental: only do a full build if pointcuts change
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P2 enhancement (vote)
Target Milestone: 1.5.3   Edit
Assignee: Adrian Colyer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-27 18:28 EST by Nicholas Lesiecki CLA
Modified: 2006-09-25 09:24 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicholas Lesiecki CLA 2005-01-27 18:28:06 EST 
Per Andy Clement on AspectJ users Jan 27, 2005

"
If you change an aspect, we currently do a full build - we could be smarter and
not do a full build if you only change the advice or any methods in the aspect,
it is really only if you change the pointcuts that we need a full build. 
"

I know this has been discussed before, but I didn't find an open bug.
Comment 1 Adrian Colyer CLA 2005-03-23 09:26:08 EST 
marking against m4. Also note, we need to rebuild if the body of inlined around
advice is changed...
Comment 2 Adrian Colyer CLA 2005-10-28 06:06:37 EDT 
additional incremental compilation improvements, including this one, will be considered in 1.5.1.
Comment 3 Andrew Clement CLA 2006-04-04 14:08:44 EDT 
this should behave much better in 1.5.1 - but there is one exception, ITDs are likely to still cause full builds.  Just having them in your aspect and yet making  pure 'whitespace' changes to aspects will trigger a full build.  Leaving open for investigation, problem is typemunger equals logic in replaceWith() code in xcutting members set which compares an eclipse and bcel type munger for the same ITD and considers them different.
Comment 4 Andrew Clement CLA 2006-05-30 09:49:15 EDT 
type munger comparison is now fixed, but Adrians comment about rebuilding if an around advice changes (because it may be getting inlined) indicates a bug I think we have at the moment!! we haven't allowed for that case in our recent changes.
Comment 5 Andrew Clement CLA 2006-09-25 09:24:19 EDT 
inlined around advice is now handled too - wooo !