Comment 1 Frederic Fusier 2005-02-27 18:03:42 EST

Fixed.

I've described selection behavior in complete document attached with bug 81377
and have to figure out how to put document it in eclipse...

[jdt-core-internal]
No test case added. Only existing ones modified to match described behavior.

Comment 2 Markus Keller 2005-03-02 06:29:35 EST

Frederic, this bug was not about generic type parameters, but about the "old"
method parameters. For example, when searching for occurrences of method m in
the code below, some of the matches include the parameter list (in parentheses)
and others don't:

package p;
import static p.A.m;
/**
 * @see A#m(int)
 */
class A {
    static void m(int i) {
        p.A.m(i);
    }
}

For AST-based refactorings, we have to map search results back to ASTNodes. This
is e.g. done in ChangeSignatureRefactoring#createOccurrenceUpdate(..): the
ASTNode is the first node that encloses a SearchMatch's source range. The code
there is specially tailored to the current behavior of the search engine, but I
would like to have a more uniform mapping.

I think it's also strange for other users of the search engine, that the
parameter list is sometimes included and sometimes it's not.

Comment 3 Frederic Fusier 2005-03-07 09:28:46 EST

Only happens for methods/constructors references in Javadoc (see your example)

Comment 4 Frederic Fusier 2005-03-07 11:23:06 EST

Markus, fix is ready but have some impact on JDT-UI refactoring tests.
Following tests fail in ChangeSignatureTests:
  - testAll58
  - testAll59
  - testAll60
  - testEnum02
  - testVararg05

If I modify ChangeSignatureRefactoring.createOccurenceUpdate method (see patch
I'll attach later), then all these tests are OK.

Let me know when you'll be able to modify these tests then I'll release this
fix, thx

Comment 5 Frederic Fusier 2005-03-07 11:24:37 EST

Created attachment 18487 [details]
Patch which fixes this bug

Apply this patch in HEAD stream on org.eclipse.jdt.core project...

Comment 6 Frederic Fusier 2005-03-07 11:27:10 EST

Created attachment 18488 [details]
Patch which fixes JDT/UI refactoring failing tests

This patch was made on top of org.eclipse.jdt.ui project, version
v20050301-0800.

Comment 7 Markus Keller 2005-03-08 04:11:51 EST

Frederic, I released a workaround, such that Change Method Signature doesn't
care about parameter inclusion. You can release your patch whenever you like.

Do I see that right, that method declarations and references to enum
constructors won't include the parameters list? E.g. search for references to
Color(int):

enum Color {
    RED, GREEN(), BLUE(17), PINK(1) {/*anon*/};
    Color() {}
    Color(int i) {}
}

-> the range is only "BLUE", not "BLUE(17)"

Comment 8 Frederic Fusier 2005-03-08 07:30:05 EST

Fixed.

Now contructor/method references in javadoc also include parameters list.

[jdt-core-internal]
Changes done in JavadocParser.createMethodReference(...)
Existing tests modified + test case added in JavaSearchBugsTests

Comment 9 Olivier Thomann 2005-03-30 15:55:13 EST

Verified in I20050330-0500

Comment 10 Frederic Fusier 2005-03-30 15:59:14 EST

Unfortunately, I missed comment 7 and didn't fix this specific issue.
I've opened a new bug for it: bug 89686...