Bug 82115 - setInput is called twice by SSE Editors
Summary: setInput is called twice by SSE Editors
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.sse (show other bugs)
Version: 0.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.0 M3   Edit
Assignee: Amy Wu CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2005-01-03 18:34 EST by David Williams CLA
Modified: 2005-06-15 23:08 EDT (History)
1 user (show)

See Also:


Attachments
org.eclipse.wst.sse.ui.patch (4.83 KB, patch)
2005-01-04 03:57 EST, Amy Wu CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2005-01-03 18:34:50 EST
for historical reasons, setInput is called in SSE's createPart control. This is 
obvious drain on startup performance, worse now that we're trying to fit into
FileBuffer framework and all its related to.
Comment 1 David Williams CLA 2005-01-03 18:39:46 EST
Assigning to you Amy, since you've investigated in the past. Let me know if 
those past solutions no longer apply, or need more discussion of alternatives. 
Comment 2 Amy Wu CLA 2005-01-04 03:47:04 EST
setInput was called again in createPart control to initialize items associated 
with the sourceviewer that were not able to be initialized the first time 
setInput was called (becaues the sourceviewer had not been created yet)

Instead of setting the input all over again, a new method, 
initializeSourceViewer should be created to just handle initializing everything 
that was missed in the first setInput (sourceviewer, viewerselectionmanager, 
etc)
Comment 3 Amy Wu CLA 2005-01-04 03:57:04 EST
Created attachment 16905 [details]
org.eclipse.wst.sse.ui.patch

While investigating, I also noticed sourceViewer.config was being called twice
in createPartControl.  This patch fixes the code so that setInput and
sourceViewer.config should only be called once.
Comment 4 David Williams CLA 2005-01-04 10:35:24 EST
just adding performance keyword
Comment 5 David Williams CLA 2005-01-04 10:40:15 EST
Thanks, Amy. I committed your patch to head, should be in builds > 1/4/05. 
Comment 6 David Williams CLA 2005-06-15 23:08:27 EDT
done