Bug 81086 - Visualiser stripes overlap the bottom borders of bars
Summary: Visualiser stripes overlap the bottom borders of bars
Status: RESOLVED FIXED
Alias: None
Product: AJDT
Classification: Tools
Component: UI (show other bugs)
Version: 1.2.0 M2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.2.1   Edit
Assignee: Matt Chapman CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-12-15 05:50 EST by Sian January CLA
Modified: 2005-08-17 05:59 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sian January CLA 2004-12-15 05:50:26 EST
To reproduce, install the Spacewar example and build with the 'debug' build 
configuration.  The bottom stripe on the Ship class overlaps the bottom border 
of the bar in normal mode (100% zoom) and when zoomed in and out.
Comment 1 Matt Chapman CLA 2005-08-16 10:16:24 EDT
Fixing this by changing the stripe geometry processing to include the following
logic:
  - after calculating initial bounds of each stripe, try to separate overlapping
stripes by moving them up or down a pixel, but only when this doesn't move the
stripe off the top or bottom of the column
  - after this, loop through the stripes again, and check that each one doesn't
spill over the bottom of the column. If it does, try to move it upwards to be
back within the column. If the column is too small to do this without the stripe
then going off the top, move it up as much as possible, then reduce its height
so that it does completely fit.

This should mean that stripes will now always be fully contained within their
parent column, regardless of stripe height or position. The result of this is
that stripes may end up with a reduced height, or they may overlap other
stripes, but this is better than spilling out of the containing column.

Comment 2 Matt Chapman CLA 2005-08-17 05:59:10 EDT
Fixed for 1.2.1:

BUILD COMPLETE -  build.508
Date of build: 08/17/2005 09:59:50
Time to build: 45 minutes 47 seconds
Last changed: 08/17/2005 09:43:45

Fixed for 1.3.0:

BUILD COMPLETE -  build.61
Date of build: 08/16/2005 16:35:57
Time to build: 27 minutes 40 seconds
Last changed: 08/16/2005 16:08:35

Manual test added.