Bug 80876 - should do unit test comparisons based on workspace, not filesytem
Summary: should do unit test comparisons based on workspace, not filesytem
Status: RESOLVED WONTFIX
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.html (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P5 enhancement (vote)
Target Milestone: ---   Edit
Assignee: David Williams CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2004-12-13 16:47 EST by David Williams CLA
Modified: 2010-04-29 17:20 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2004-12-13 16:47:22 EST
In current builds, html.core and css.core unit tests fail, even though they work
correctly when ran in dev. envonment. The (primary) reason for this, is that 
the tests looks for some "reference files" to compare current results against. 
The problem is, that it looks for these reference files in a directory matching
plugin ID, but on build machine, the directory is named pluginID_1.0.0. 

A better approach is to zip up the reference files, and unzip them into target
workspace, as we do for encoding tests ... and then compare current results with
those reference files in the target workspace. The current results would also
have to be written to target workspace, instead of directly to file system.
Comment 1 David Williams CLA 2004-12-13 16:49:53 EST
Marking as P2, since unit tests should be working for milestone 2. 
Comment 2 David Williams CLA 2004-12-15 10:57:50 EST
Decided to leave this bug open, and fix next Milestone, in the 
interest of simplity. The failing unit tests will be removed from 
current suite. This isn't a bad sign, since when run "locally" they 
do run ok, so its just a test improvement. Test improvements can be done 
later. 
Comment 3 David Williams CLA 2004-12-18 13:10:48 EST
Changed abstract since Phil (I think it was) found the tests were broken 
due to simple build error (reference files were no in build.properties file). 

But, I still think its a good idea to use workspace, instead of direct file 
system, so have changed to "enhancement". 
Comment 4 David Williams CLA 2007-09-04 01:23:33 EDT
not very important, but, maybe someone would want to help improve this tests in this small way. 
Comment 5 Peter Liu CLA 2009-05-06 12:09:06 EDT
Hi, everyone.
This bug was opened in 2004. David's comment in 2007 asked for improving the test.
Is there still a need for that? Thanks.

Peter.
Comment 6 Nick Sandonato CLA 2010-04-29 17:20:19 EDT
I don't think this is something that will be gotten around to.