Bug 80384 - Cannot decode package signature from CompletionProposal
Summary: Cannot decode package signature from CompletionProposal
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 M4   Edit
Assignee: David Audel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-12-07 11:53 EST by Markus Keller CLA
Modified: 2004-12-14 10:56 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2004-12-07 11:53:16 EST 
From the javadoc of CompletionProposal#getDeclarationSignature():
	 * 	<li><code>PACKAGE_REF</code> - dot-based package 
	 * signature of the package that is referenced</li>
...
	 * @see Signature

But class Signature does not offer methods to decode package signatures.
Comment 1 Markus Keller CLA 2004-12-07 12:16:58 EST 
Actually, the signature of a package seems to be equivalent to the package name.
If this is a general rule, then we don't need new API. But this should be
documented (maybe best in CompletionProposal#getDeclarationSignature() as well
as in Signature).
Comment 2 David Audel CLA 2004-12-08 10:20:14 EST 
dot-based package signature (eg: 'java.lang') does not need to be decoded,
that's just the package name.
Type signature (eg: 'Lp/q/X<Lp/Y;>.Z;')and method signature (eq: '(Lp/q/X)V')
are like classfile signature and can be decoded by class Signature.

Jim - could we change javadoc of getDeclarationSignaure()or replace inside
javadoc 'dot-based package signature' by 'dot-based package name' to be less
ambigous  ?
Comment 3 Jim des Rivieres CLA 2004-12-08 11:35:20 EST 
I've clarified specs for CompletionProposal as suggested.
Updated build notes. Closing.
Comment 4 Frederic Fusier CLA 2004-12-14 10:56:12 EST 
Verified for 3.1 M4 using build I200412140800.