Bug 80156 - [plan item] Improve support for externalized strings
Summary: [plan item] Improve support for externalized strings
Status: CLOSED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P4 enhancement (vote)
Target Milestone: 3.1   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: plan
Depends on:
Blocks:
 
Reported: 2004-12-03 14:46 EST by Jim des Rivieres CLA
Modified: 2005-04-15 06:06 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim des Rivieres CLA 2004-12-03 14:46:37 EST
Provide a separate properties file editor, and enhance the Java editor to 
display the value of and navigate from an NLS key in code and the 
corresponding entry in the properties file. [JDT Text]
Comment 1 Uwe Voigt CLA 2004-12-21 14:40:45 EST
It would be good to have a tooltip that displays the value of an
externalized string when hovering over the property key in the Java Editor
(maybe that is already in the works).
Currently that tooltip displays the type info of the current type if the
externalize strings refactoring wizard finished with the initial resource key
prefix suggestion left unchanged.
(this was added as 81750 initially which could be marked as duplicate)
Comment 2 Dani Megert CLA 2004-12-22 03:14:21 EST
Checkout 3.1 M4: besides feature 81750 it also contains:
- navigate from Java Editor to Properties file Ctrl + Mouse-click
- syntax coloring for properties files
- spell checking in Properties file editor
- navigation from key in Properties file to its references via Open (F3) and 
  Ctrl + Mouse-click
Comment 3 Axel Gross CLA 2005-01-04 04:44:44 EST
Thanks first for the great enhancements!
But I have one trouble and one enhancement proposal:

First the enhancement proposal (use of multiple message resource files):
Another checkbox: 'Filter all from other accessor class'
Which should filter all those entries from accessor classes different from the 
one currently specified in drop-down 'Accessor class': 
(at the moment they give a trouble marker ('Entry is missing in properties 
file'))
This is needed for working with multiple message files, as else the wizard 
always gets cluttered by the trouble markers.

Bug zoo:
I didn't check out from CVS, but for a (fresh) 3.1 M4 build:
>> Checkout 3.1 M4: besides feature 81750 it also contains:
>> - navigate from Java Editor to Properties file Ctrl + Mouse-click
Doesn't work. Tried on key string ("FooClass.key"), marker (//$NON-NLS-1$).
Nothing happens there.
For Message class and method usual Java navigation works (as it should).

>> - syntax coloring for properties files
>> - spell checking in Properties file editor
>> - navigation from key in Properties file to its references via Open (F3) and 
>>  Ctrl + Mouse-click
thanks, thanks, thanks :)
Comment 4 Dani Megert CLA 2005-01-04 05:11:19 EST
Axel, please file a bug report for the bug with steps to reproduce and a feature
request for the feature. If we decide to implement your feature we can link it
to this plan item.
Comment 5 Uwe Voigt CLA 2005-04-13 03:43:41 EDT
The Eclipse style of externalizing strings into a static string fields
(introduced with 3.1M6) is a great, long awaited enhancement. But for the moment
it lacks the value lookup provided by a hover.
I thought of a solution that adds the value as javadoc to the static fields but
that is not as consistent as it is now with the bundle-based lookup.
But maybe the NLSHintHelper could be enhanced to also look for references to
static fields within types with a resource bundle.
Comment 6 Dani Megert CLA 2005-04-13 04:44:31 EDT
The tooling for the "standard" NLS approach was already done once the new style
was introduce. There was not enough time to provide the same tooling for it. We
only adapted the Externalize Strings wizard.

For 3.2 the following will have to be done for the new approach:
- Eclipse NLS Search
- Eclipse NLS hover
- Eclipse NLS hyperlinking
Comment 7 Dani Megert CLA 2005-04-15 05:29:15 EDT
see also bug 91500.
Comment 8 Dani Megert CLA 2005-04-15 06:06:58 EDT
.