Bug 78698 - [format] Space before ? should default to false
Summary: [format] Space before ? should default to false
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.1 M5   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 81085
  Show dependency tree
 
Reported: 2004-11-16 04:25 EST by Markus Keller CLA
Modified: 2005-02-16 09:56 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2004-11-16 04:25:08 EST 
200411111200

Not to be changed for I20041116.

The code formatter setting for White Space > Insert Space > Before question mark
should default to false for all profiles.

Was: List< ? extends Number>
Expected: List<? extends Number>
Comment 1 Markus Keller CLA 2004-12-13 03:46:09 EST 
Note that jdt.ui should be informed when this change happens. We have test cases
that need to be adapted.
Comment 2 Olivier Thomann CLA 2004-12-13 14:08:43 EST 
This can be fixed for M4 if you wish. or we simply wait after m4. It is up to you.
Comment 3 Markus Keller CLA 2004-12-14 13:34:33 EST 
Sorry, forgot to answer this. Let's do it early next year. IMO it's minor and
not worth the hassle.
Comment 4 Olivier Thomann CLA 2004-12-14 13:35:58 EST 
Ok, tagged as 3.1M5.
Comment 5 Markus Keller CLA 2005-01-03 07:01:36 EST 
Both "Before question mark > Wildcard Type" and "After question mark > Wildcard
Type" should default to false.

Otherwise, e.g. a reference List<?> would still get unwanted spaces.
Comment 6 Olivier Thomann CLA 2005-01-05 10:48:52 EST 
My fix is ready. Let me know when I can release it.
Comment 7 Olivier Thomann CLA 2005-01-05 11:12:16 EST 
Fixed and released in HEAD.
Regression test added in FormatterRegressionTests.test534-test537.
Comment 8 Markus Keller CLA 2005-01-05 14:55:20 EST 
I've updated the JDT-UI tests. Everything's smooth now.
Comment 9 David Audel CLA 2005-02-16 09:56:02 EST 
Verified in I20050215-2300