Comment 1 Frederic Fusier 2004-11-19 04:04:32 EST

Theoretically directoryList should NOT be null...
It is initialized at the beginning of the search while computing classpath
entries and reset at the end of the search to release memory...

It would be really helpful if you can find a small test case which can help me
to reproduce the problem and see where I miss to set this variable. The best
thing would be to put your class de.hmorga.util.Format in a new workspace, fix
all compilation errors by reducing the code at the maximum but always getting
the NPE while searching.

Of course, if you cannot find an example to reproduce it easily, I'll apply the
solution to verify that this variable is not null but it would be only fix the
consequence not the cause of the problem...
Thx

Comment 2 Nico Seessle 2004-11-20 15:48:50 EST

Wow, that was hard to reproduce. The smallest test-case which I could produce
still weights in with ~700kB (hope that's not a big problem).

I think any other jar file than ant.jar would work to reproduce the bug, unless
it contains a method with the same signature that you are searching for - but
this is just a rough guess, and I was too lazy (already spent several hours to
bring it down to ~700kB) to produce a smaller example.

- Create a new Workspace-Directory (outside Eclipse)
- Extract the attached ZIP into this directory
- launch Eclipse 3.1M3 and specify the directory as the workspace
- create two java projects (reusing the extracted zip), in the order "p3", "p2"
- fix the classpath for "P2" (the "ant.jar" is contained in the project "P2",
but MUST be added thru "add external jar" to reproduce the problem)
- open the class "Format" in "P3" and do a "search, references, workspace" for
"format(long d, String format)"
=> WORKS OK, this is as expected!
- go to preferences, java, installed jres; add a new "JRE" (but use a JDK!) and
specifiy this as the default (jdk 1.4.2_05 and 1.5.0 worked for me for the next
steps to reproduce the problem); set the JDK as the default
- doing ths search again now causes the stack-trace mentioned in the bud report.

Comment 3 Nico Seessle 2004-11-20 15:49:59 EST

Created attachment 16031 [details]
zipped Projects used to reproduce the problem

Comment 4 Nico Seessle 2004-11-20 16:17:47 EST

Ah, crap...

Note to self: don't try to reduce things more than needed.

Will add a new attachment, as the current one seems to work only once (when
restarting eclipse everything seems to work well). The new examples survived
three restarts (and probably will survive more) and should make debugging easier.

- Now there are three projects
- the jar files (for P2) are in the sub-directory "xxx", which is NOT a eclipse
project

Additional note: 
- removing the source-attachment from the jdk-rt.jar removed the problem
- adding a source-attachment to the jre-rt.jar also causes the problem

Comment 5 Nico Seessle 2004-11-20 16:19:24 EST

Created attachment 16032 [details]
zipped Projects used to reproduce the problem

Comment 6 Frederic Fusier 2004-11-21 07:53:56 EST

I'm able to get the exception now...
Thanks for these detailed instructions and test case.

Comment 7 Frederic Fusier 2004-11-21 08:24:54 EST

Here's the minimal test case to reproduce:
Project P2:
.classpath:
<?xml version="1.0" encoding="UTF-8"?>
<classpath>
	<classpathentry kind="src" path=""/>
	<classpathentry kind="src" path="/P3"/>
	<classpathentry kind="con"
path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/1.4.2"/>
	<classpathentry kind="lib"
path="D:/e/v31/eclipse/plugins/org.apache.ant_1.6.2/lib/ant.jar"/>
	<classpathentry kind="output" path=""/>
</classpath>

Project P3:
.classpath:
<?xml version="1.0" encoding="UTF-8"?>
<classpath>
	<classpathentry kind="src" path=""/>
	<classpathentry sourcepath="JRE_SRC" kind="var" path="JRE_LIB"/>
	<classpathentry kind="output" path=""/>
</classpath>
Format.java:
public class Format {
    public static String format(double d, String format) {
        return "";
    }

    public static String format(long d, String format) {
        return "";
    }

}

Workspace default JRE: 1.5.0

Search for reference in workspace to method format(long,String) from Outline
view and then you'll get Java Search error dialog:
An internal error occured during: "Java Search"

Comment 8 Frederic Fusier 2004-11-21 11:26:17 EST

Fixed.

The NPE does no longer happen now.

[jdt-core-internal]
Change done in MatchLocator#initialize(IJavaProject,int).
JavaSearchNameEnvironment was always cleaned-up although it is reused when
there's only oe possible match.
No test case added as it was too complex to reproduce using JUnit tests.
Run scenario described in comment 7 to verify that it's fixed.

Comment 9 Olivier Thomann 2004-12-14 11:51:13 EST

Verified in 200412140800