Bug 77358 - [implementation] Release lock on CU prior to model change notification
Summary: [implementation] Release lock on CU prior to model change notification
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-01 06:34 EST by Christof Marti CLA
Modified: 2023-04-07 00:25 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christof Marti CLA 2004-11-01 06:34:39 EST 
Currently the JavaReconcilingStrategy (and others) holds a lock on the CU during
the entire reconcile() including the model change notification. Holding a lock
when notifying listeners is deadlock prone.

The suggested solution is to essentially put the synchronized block in
IWorkspaceRunnable and call JavaCore#run(IWorkspaceRunnable, ISchedulingRule,
IProgressMonitor) with a ISchedulingRule for the CU. Model change notification
happens only after the runnable was called.
Comment 1 Dani Megert CLA 2004-11-01 14:01:13 EST 
Need also revisit other callers of reconcile() in JDT Text and JDT UI land.
Comment 2 Dani Megert CLA 2005-05-27 04:11:55 EDT 
Deferred.
Comment 3 Eclipse Genie CLA 2019-04-20 13:35:08 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 4 Eclipse Genie CLA 2021-04-13 14:57:43 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 5 Eclipse Genie CLA 2023-04-07 00:25:12 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.