Bug 77125 - Preference for suspending VM on breakpoint
Summary: Preference for suspending VM on breakpoint
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.2 M6   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
: 107223 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-10-27 11:43 EDT by DJ Houghton CLA
Modified: 2006-04-06 16:11 EDT (History)
3 users (show)

See Also:

Attachments
Patch: Adds option to change default suspension method (3.41 KB, patch)
2005-11-25 13:06 EST, Gary Barbon CLA 		no flags Details | Diff
Changes storage style of previous patch from Boolean to Int (3.77 KB, patch)
2005-12-02 10:55 EST, Gary Barbon CLA 		no flags Details | Diff
patch (16.13 KB, patch)
2006-02-24 11:16 EST, Michael Rennie CLA 		no flags Details | Diff
updated patch (12.26 KB, patch)
2006-03-07 22:43 EST, Darin Wright CLA 		no flags Details | Diff
updated patch (79.52 KB, patch)
2006-03-09 16:09 EST, Michael Rennie CLA 		no flags Details | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2004-10-27 11:43:04 EDT 
build i1026.

You are able to configure a breakpoint's properties so it suspends either the
thread or the whole VM when it is hit.

I would like to have a preference so I can change my default to be the VM.
(useful when tracking down concurrency problems)
Comment 1 Darin Wright CLA 2005-04-04 10:55:56 EDT 
Deferred
Comment 2 Darin Wright CLA 2005-08-17 13:47:26 EDT 
*** Bug 107223 has been marked as a duplicate of this bug. ***
Comment 3 Darin Wright CLA 2005-08-17 13:47:46 EDT 
open for 3.2
Comment 4 Gary Barbon CLA 2005-11-25 13:06:35 EST 
Created attachment 30629 [details]
Patch: Adds option to change default suspension method

Adds to the Java Debug Preferences Page the option to change default suspension method of breakpoints upon their creation. Subsequent breakpoints created will have the default suspension method specified in the Java Debug Preferences Page option.
Comment 5 Gary Barbon CLA 2005-11-29 15:10:14 EST 
Assigning to Darin for review.
Comment 6 Darin Wright CLA 2005-12-02 09:37:05 EST 
I think the design/impl would work better/simpler if the preference was an Integer storing the default suspend policy - i.e. PREF_DEFAULT_BREAKPOINT_SUSPEND_POLICY. The value would be one of IJavaBreakpoint.SUSPEND_VM or IJavaBreakpoint.SUSPEND_THREAD.
Comment 7 Gary Barbon CLA 2005-12-02 10:55:21 EST 
Created attachment 31031 [details]
Changes storage style of previous patch from Boolean to Int

Patch: addresses concern in Comment #6, so that the value is now stored in an extensible Integer format, referenced by the suggested constant.
Comment 8 Gary Barbon CLA 2005-12-02 10:56:41 EST 
assigning to Darin for review.
Comment 9 Michael Rennie CLA 2006-02-24 11:16:44 EST 
Created attachment 35311 [details]
patch

reworked entire patch, as it seems to be hosed
Comment 10 Michael Rennie CLA 2006-02-24 11:17:29 EST 
please verify Darin.
Comment 11 Darin Wright CLA 2006-03-07 22:43:10 EST 
Created attachment 35885 [details]
updated patch

Updates to reflect other changes in the same classes
Comment 12 Darin Wright CLA 2006-03-07 22:50:01 EST 
I think this feature should be re-worked to only effect newly created breakpoints rather than all existing Java breakpoints. The preference description should be updated to reflect this - something like "Newly created breakpoints suspend entire VM by default".
Comment 13 Michael Rennie CLA 2006-03-09 16:09:55 EST 
Created attachment 36021 [details]
updated patch

patch changes the intention of the pref, and applies it only to newly created breakpoints.
Comment 14 Michael Rennie CLA 2006-03-09 16:11:17 EST 
please verify Kevin
Comment 15 Darin Wright CLA 2006-03-14 13:09:16 EST 
Fixed. Applied patch with some changes. The UI for the perference is now a combo box.
Comment 16 Darin Wright CLA 2006-03-14 13:09:32 EST 
Please verify, Mike.
Comment 17 Michael Rennie CLA 2006-03-14 14:48:52 EST 
verified