Bug 75364 - [plan item] Refactoring support
Summary: [plan item] Refactoring support
Status: RESOLVED DUPLICATE of bug 181493
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 2.0.2   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: plan
Depends on:
Blocks:
 
Reported: 2004-09-30 04:23 EDT by Markus Schorn CLA
Modified: 2007-11-14 04:09 EST (History)
22 users (show)

See Also:


Attachments
first plan of intent (84.85 KB, application/pdf)
2004-09-30 04:29 EDT, Markus Schorn CLA
no flags Details
The LaTex source of the document (8.99 KB, text/plain)
2004-09-30 08:54 EDT, Michael Scharf CLA
no flags Details
first plan of intent (84.85 KB, application/pdf)
2004-09-30 09:07 EDT, Markus Schorn CLA
no flags Details
The LaTex source of the document (8.99 KB, text/plain)
2004-09-30 15:44 EDT, Michael Scharf CLA
no flags Details
Proposal (html) (19.19 KB, text/html)
2004-10-05 04:14 EDT, Markus Schorn CLA
no flags Details
Proposal (ms-word) (31.50 KB, application/msword)
2004-10-05 04:16 EDT, Markus Schorn CLA
no flags Details
Updated Proposal (html) (88.43 KB, text/html)
2004-10-11 04:56 EDT, Markus Schorn CLA
no flags Details
Updated Proposal (ms-word) (66.00 KB, application/msword)
2004-10-11 04:56 EDT, Markus Schorn CLA
no flags Details
+ AST requirements (html) (93.28 KB, text/html)
2004-10-18 09:38 EDT, Markus Schorn CLA
no flags Details
+ AST requirements (ms-word) (80.00 KB, application/msword)
2004-10-18 09:38 EDT, Markus Schorn CLA
no flags Details
JDT Inline Constant Refactoring Walkthrough (5.20 KB, text/html)
2004-10-26 15:42 EDT, Doug Schaefer CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Schorn CLA 2004-09-30 04:23:35 EDT
This feature shall add refactoring support to CDT by making use of the 
refactoring framwork of JDT. Furthermore by doing so, the plan is to 
provide an AST rewrite facility that may also be reused for quick-fixes, 
code formatting or other operations modifying the source code.
Comment 1 Markus Schorn CLA 2004-09-30 04:29:44 EDT
Created attachment 14920 [details]
first plan of intent

The document describes a scenario of extending CDT whith refactoring
capabilities and shall serve as the foundation for further discussions.
Comment 2 Nikolay Metchev CLA 2004-09-30 04:58:15 EDT
the attached PDF seems to be corrupt!
Comment 3 Michael Scharf CLA 2004-09-30 08:54:48 EDT
Created attachment 14929 [details]
The LaTex source of the document

The pdf works for me (I had to download it and then open the downloaded file).
I appached the LaTex source of the file...
Comment 4 Markus Schorn CLA 2004-09-30 09:07:36 EDT
Created attachment 14930 [details]
first plan of intent

second try to upload pdf.
Comment 5 Doug Schaefer CLA 2004-09-30 10:27:21 EDT
Great interest so far! As with other bugs of this variety, I am assigning to 
Markus as owner.
Comment 6 Brent Nicolle CLA 2004-09-30 14:12:05 EDT
Something is still wrong with the PDF file, even if separately downloaded.
I was able to view it using xpdf on Linux, but unable to view 
it using Adobe's reader for Windows (AcroRd32.exe 4.0, 5.0, or 6.0).

BTW, the TEX file is twice as long as it needs to be;
it repeats itself at line 226.
Comment 7 Michael Scharf CLA 2004-09-30 15:44:16 EDT
Created attachment 14935 [details]
The LaTex source of the document

The pdf works for me (I had to download it and then open the downloaded file).
I appached the LaTex source of the file...
Comment 8 Michael Scharf CLA 2004-09-30 16:02:51 EDT
The problem latex file is repeated seems to be a bug in bugzilla. I reattached 
the file and when I download it, it gets repeated after a line: 
  Content-Type: text/plain

What would be the best format for such a document?
Comment 9 Markus Schorn CLA 2004-10-05 04:14:01 EDT
Created attachment 14995 [details]
Proposal (html)
Comment 10 Markus Schorn CLA 2004-10-05 04:16:07 EDT
Created attachment 14996 [details]
Proposal (ms-word)
Comment 11 John Camelon CLA 2004-10-05 15:54:52 EDT
From the document: 
> The core of the text search of the eclipse platform is found in an 
> internal package. Shall we ask for a public interface to it, or is 
> it acceptable to access the internal part?

I would raise a feature request on the platform to gain legitimate access to 
text search engine.
 
Comment 12 John Camelon CLA 2004-10-05 16:21:29 EDT
Regarding packaging/modules: 

Configuring a parser is not an act limited to the refactoring framework.  
Several other CDT features also do this work.  While I am indifferent as to 
whether or not refactoring goes into its own plugin or into the cdt.ui plugin, 
I believe that this extension point (as you have described it) belongs more in 
the cdt.core.  
Comment 13 Markus Schorn CLA 2004-10-11 04:56:28 EDT
Created attachment 15092 [details]
Updated Proposal (html)

Added an analysis of the proposed refactorings
Comment 14 Markus Schorn CLA 2004-10-11 04:56:58 EDT
Created attachment 15093 [details]
Updated Proposal (ms-word)

Added an analysis of the proposed refactorings
Comment 15 Markus Schorn CLA 2004-10-18 09:38:26 EDT
Created attachment 15245 [details]
+ AST requirements (html)

Added a list of requirements towards the AST.
Comment 16 Markus Schorn CLA 2004-10-18 09:38:59 EDT
Created attachment 15247 [details]
+ AST requirements (ms-word)
Comment 17 Doug Schaefer CLA 2004-10-26 15:42:46 EDT
Created attachment 15405 [details]
JDT Inline Constant Refactoring Walkthrough

Here is a walkthrough that I did while debugging JDT's Inline Constant
refactoring. It provides a very interesting insight into how JDT's AST is used
to perform semantic checking and how JDT's search and AST is used along with an
ASTRewriter and ASTRewriterAnalyzer to create text edits to accomplish changes
and even uses a Reformatter to make sure the changes look pretty.

In the end, this looks like a great way, although complex, to do refactoring.
How we accomplish this with C/C++, with preprocessing and other goodies, needs
to be a road carefully travelled.
Comment 18 Markus Schorn CLA 2006-05-05 09:50:40 EDT
The rename refactoring was implemented in 3.0, returning the rest to the inbox.
Comment 19 Markus Schorn CLA 2007-11-14 04:09:19 EST

*** This bug has been marked as a duplicate of bug 181493 ***