Bug 73658 - [1.5] Not all new 1.5 formatter options seem to work
Summary: [1.5] Not all new 1.5 formatter options seem to work
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 M6   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 77701
  Show dependency tree
 
Reported: 2004-09-10 09:00 EDT by Martin Aeschlimann CLA
Modified: 2005-03-30 19:15 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2004-09-10 09:00:35 EDT 
20040910

I updated the UI to include the new code formatter options (bug 72046)
Not all optins seems to work correctly:
- white spaces in enum types
- white spaces in annotation types
- space after wildcard question mark
- new lines in enum (it has also parsing problems in new lines preview)
- line wrapping with enums
Comment 1 Olivier Thomann CLA 2004-09-10 10:31:13 EDT 
As soon as I can get the new code formatter preference page, I will check the
new options.
Comment 2 Markus Keller CLA 2004-11-16 12:44:46 EST 
All options for space before and after Type arguments also don't do anything.
Comment 3 Trevor Robinson CLA 2005-03-15 12:32:19 EST 
I've encountered this too. My TestEnum formats like this:

public enum TestEnum {
    X {
        void foo()
        {
        }
    },
    Y, Z;
}

even though I have 'Brace positions' for 'Enum declaration' and 'Enum constant
body' set to 'Next line'. Strangely, the preview is formatted correctly:

enum MyEnum
{
    UNDEFINED(0)
    {
        void foo()
        {
        }
    }
}
Comment 4 Olivier Thomann CLA 2005-03-15 12:34:47 EST 
Trevor, what build are you using?
Comment 5 Trevor Robinson CLA 2005-03-15 14:17:10 EST 
(In reply to comment #4)
> Trevor, what build are you using?

N20050303-0010
Comment 6 Olivier Thomann CLA 2005-03-29 14:37:50 EST 
Closing as FIXED since I cannot reproduce the problem in comment 4 and problems
reported in description have been fixed.
The only remaining option with no effect is the space before the '@' in the
annotation type. I don't see how it is possible to have such space. We should
deprecate this option and remove it post M6.
What do you think?
Comment 7 Olivier Thomann CLA 2005-03-29 14:38:25 EST 
I meant problem reported in comment 3.
Comment 8 Olivier Thomann CLA 2005-03-30 19:15:35 EST 
Verified in 20050330-0500