Bug 73551 - [Search] NPE while searching package declaration
Summary: [Search] NPE while searching package declaration
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0.2   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-09-09 10:15 EDT by Frederic Fusier CLA
Modified: 2005-03-10 05:06 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2004-09-09 10:15:59 EDT 
Using 3.0.1 RC2.
Looking at bug 71267, I tried to perform a search of package p declaration and
got following NPE stack trace:
An internal error occurred during: "Java Search".
java.lang.NullPointerException
org.eclipse.jdt.internal.ui.search.NewSearchResultCollector.acceptSearchMatch(NewSearchResultCollector.java:31)
org.eclipse.jdt.internal.core.search.matching.MatchLocator.report(MatchLocator.java:1199)
org.eclipse.jdt.internal.core.search.matching.MatchLocator.locatePackageDeclarations(MatchLocator.java:929)
org.eclipse.jdt.internal.core.search.matching.MatchLocator.locatePackageDeclarations(MatchLocator.java:912)
org.eclipse.jdt.internal.core.search.JavaSearchParticipant.locateMatches(JavaSearchParticipant.java:99)
org.eclipse.jdt.core.search.SearchEngine.findMatches(SearchEngine.java:468)
org.eclipse.jdt.core.search.SearchEngine.search(SearchEngine.java:757)
org.eclipse.jdt.internal.ui.search.JavaSearchQuery.run(JavaSearchQuery.java:125)
org.eclipse.search2.internal.ui.InternalSearchUI$InternalSearchJob.run(InternalSearchUI.java:83)
org.eclipse.core.internal.jobs.Worker.run(Worker.java:66)
Comment 1 Frederic Fusier CLA 2004-09-09 10:18:04 EDT 
Although NPE was in JDT/UI land, it comes from JDT/Core...
MatchLocator.newDeclarationMatch(
		IJavaElement element,
		int accuracy,
		int offset,  
		int length,
		SearchParticipant participant, 
		IResource resource)
method returns null as it seems that no match was instanciated for
PackageDeclaration element type...
Comment 2 Frederic Fusier CLA 2004-09-13 07:30:03 EDT 
Fixed and released in HEAD.
This bug will be targeted for 3.0.2 when available and released in
R3_0_maintenance stream after 3.0.1 is shipped...

Now package declaration can be searched without any error and returns correct
result.

[jdt-core-internal]
Changes done in MatchLocator.newDeclaration(...) method.
Test cases added in JavaSearchTests
Comment 3 Frederic Fusier CLA 2004-09-20 05:06:52 EDT 
Fixed and released in R3_0_maintenance stream.
Bug Target still needs to be set to 3.0.2 when it will be available...
Comment 4 Frederic Fusier CLA 2004-09-21 09:26:48 EDT 
Setting target to 3.1 M2 while waiting for 3.0.2 one...
Comment 5 David Audel CLA 2004-09-23 11:35:39 EDT 
Verified in I200409230100.
Comment 6 Frederic Fusier CLA 2004-09-24 05:18:17 EDT 
Finally set status as VERIFIED.
We'll only change target when fix will be definitely put in R3_0_maintenance
stream...
Comment 7 Frederic Fusier CLA 2005-01-26 12:48:05 EST 
Candidating fix for 3.0.2 release (not committed yet)
Comment 8 David Audel CLA 2005-03-10 05:06:08 EST 
Verified with M20050216