Bug 73277 - [1.5][Search] Fields search does not work with generics
Summary: [1.5][Search] Fields search does not work with generics
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 M3   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-09-03 19:44 EDT by mike andrews CLA
Modified: 2004-11-02 13:21 EST (History)
1 user (show)

See Also:

Attachments
Patch file for org.eclipse.jdt.core project (52.47 KB, patch)
2004-10-08 10:47 EDT, Frederic Fusier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mike andrews CLA 2004-09-03 19:44:47 EDT 
refactored (renamed) a field named 'subscribers':

private static final Set<SubscriberRecord> subscribers = new SubscriberSet();

(SubscriberRecord and SubscriberSet just some classes i defined)

but synchronized block elsewhere in class did NOT get renamed, resulting in
errors after the refactoring. synchronization was on 'subscribers'.

thanks!
Comment 1 Dirk Baeumer CLA 2004-09-06 05:52:22 EDT 
Moving to JDT/Core since renaming a field is implemented by search for all 
references to the field and textually updating the matches. Assume that the 
reference is missing in the searchr result.
Comment 2 Kent Johnson CLA 2004-09-07 14:42:15 EDT 
Can you please attach the source for the 2 classes?
Comment 3 Frederic Fusier CLA 2004-09-17 07:05:28 EDT 
This is a general problem of search with generics... Currently it does not work
and this area needs design and implementation.
I'm currently working on it and try to provide acceptable minimum solution as
soon as possible... (not sure it can be done for M2)
Comment 4 Frederic Fusier CLA 2004-10-05 10:16:05 EDT 
Finally, due to amount of work to make search working for generics, I split it
in several bugs. This one will be for fields search only.
I will add references to other bugs when they will be created.
Comment 5 Frederic Fusier CLA 2004-10-05 10:21:07 EDT 
See also bug 76641 for types search and bug 76642 for methods/constructors search...
Comment 6 Frederic Fusier CLA 2004-10-05 11:06:27 EDT 
In comment 5, you should read:
See also bug 75641 for types search and bug 75642 for methods/constructors search...
Comment 7 Frederic Fusier CLA 2004-10-08 10:45:50 EDT 
Fixed.

Search now support paremeterized type fields.

[jdt-core-internal]
I'll add patch file for this change.
Test case added in JavaSearch15Tests
Comment 8 Frederic Fusier CLA 2004-10-08 10:47:14 EDT 
Created attachment 15065 [details]
Patch file for org.eclipse.jdt.core project

It does not include test cases
Comment 9 David Audel CLA 2004-11-02 13:21:42 EST 
Verified for 3.1M3 with build I20041101