Bug 7206 - rename method parameters panel needs work
Summary: rename method parameters panel needs work
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P2 normal (vote)
Target Milestone: 2.0 M3   Edit
Assignee: Adam Kiezun CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-12-31 12:25 EST by Howard M. Lewis Ship CLA
Modified: 2002-01-15 07:35 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Howard M. Lewis Ship CLA 2001-12-31 12:25:32 EST 
The panel for renaming methods has low usability.  The old names for the 
parameters are unsorted --- they are not in declaration order or alphabetical 
order.

If the names are not mneumonic (and why would you rename them otherwise) it is 
hard to determine what to rename them to.  That is, should "arg0" be servlet, 
mapping or request?  (I'm tripping across this renaming overloaded Struts 
action methods).

I would suggest:
1) Sort by declaration order
2) Add a column to display the type
3) Merge this and the parameter ordering panel into a single operation
Comment 1 Dirk Baeumer CLA 2002-01-10 09:20:46 EST 
Agree on 1 and 2. Item 3 is still under discussion since if we do so the 
resulting refactoring should be something like change signature.
Comment 2 Adam Kiezun CLA 2002-01-15 07:35:40 EST 
fixed 1 and 2
>= 20010115