Bug 70410 - [spell checking] Hardcoded paths make copy of workspace unusable and eventually corrupt the original one
Summary: [spell checking] Hardcoded paths make copy of workspace unusable and eventual...
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal with 2 votes (vote)
Target Milestone: 3.4 M1   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, usability
: 187773 (view as bug list)
Depends on:
Blocks: 406783
  Show dependency tree
 
Reported: 2004-07-20 07:55 EDT by Dani Megert CLA
Modified: 2013-04-30 06:10 EDT (History)
3 users (show)

See Also:


Attachments
Patch (9.46 KB, patch)
2007-07-04 12:03 EDT, Karsten Becker CLA
no flags Details | Diff
Updated Patch (8.70 KB, patch)
2007-07-05 06:29 EDT, Karsten Becker CLA
no flags Details | Diff
missed the manifest (9.45 KB, patch)
2007-07-05 06:45 EDT, Karsten Becker CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2004-07-20 07:55:37 EDT
R3.0

I copied an existing workspace but had several problems due to hard coded paths
in files. One of them was caused by the fact that user defined spell checking
dictionary can only be stored as full local path instead of relative workspace
location where applicable.

The very bad thing about this is that it points into my original workspace and I
then can get very strange behavior and even modify/corrupt the original workspace.

I think it should be possible to copy an existing workspace and then use it
without running into various problems.
Comment 1 Dani Megert CLA 2004-12-11 03:47:07 EST
To be fixed for the generalized spelling engine
Comment 2 Ville Oikarinen CLA 2005-05-20 06:04:11 EDT
I really think this is an important feature request.

Workspaces should be completely path, machine and preferably operating system
independent.

In addition, all user-specific information such as CVS usernames should be saved
in text files only. Or if it's necessary for performance to cache them in some
binary files, modifications to the text files should automatically deprecate the
caches.

This way it would finally be possible (or is it now, I don't know how?) to use
text-formatting tools (like sed) to customize a workspace for a new developer so
that the user needs to do absolutely nothing besides start eclipse. And please
do not say that automation is not needed, it is.

Users of other (inferior) IDEs and processes are reluctant to adopt our more
efficient processes, but if I am able to give them eclipse and the workspace in
a zip file that enables them to participate in the project with zero
configuration besides unzip, it may be easier to convert them :)

(Importing a Team Project Set is far from automatic, when the workspace involves
several projects one of which contains a custom builder that needs to be run in
the Eclipse JVM and stuff like that.)
Comment 3 Dani Megert CLA 2005-05-25 17:08:22 EDT
Deferred.

Comment 4 Dani Megert CLA 2006-11-24 10:42:22 EST
The idea is to also allow workspace relative dictionaries.
Comment 5 Dani Megert CLA 2007-05-18 06:15:19 EDT
*** Bug 187773 has been marked as a duplicate of this bug. ***
Comment 6 Karsten Becker CLA 2007-07-04 12:03:26 EDT
Created attachment 73037 [details]
Patch

Now that is is possible to use variables in the path it would be logical to set the default user dictionary to: {workspace_loc}/.metadata/userDictionary for example. No one cares where the user dictionary is stored. Thus having to set it up on first use is suboptimal.
Comment 7 Dani Megert CLA 2007-07-05 05:35:50 EDT
Thansk for the patch. Looks good. Just two things:
- please use the same NLS key prefix as all other strings in that class (or
  convert all other ;-)
- the new button has no mnemonic
Comment 8 Karsten Becker CLA 2007-07-05 06:29:27 EDT
Created attachment 73100 [details]
Updated Patch

Added L as mnomic
Comment 9 Karsten Becker CLA 2007-07-05 06:45:50 EDT
Created attachment 73101 [details]
missed the manifest

the manifest was missing in the last patch
Comment 10 Dani Megert CLA 2007-07-09 05:26:24 EDT
Fixed in HEAD.
Available in builds > N20070709-0010.
Comment 11 Martin Oberhuber CLA 2013-04-30 06:02:58 EDT
Since I just had to look it up , the commit was this one:

http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=d235827d8379f62fd5c488aabdec635fbb5005a2