Bug 69685 - [push down] increase visibility action for Add Required... [refactoring]
Summary: [push down] increase visibility action for Add Required... [refactoring]
Status: NEW
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-08 20:08 EDT by David Corbin CLA
Modified: 2007-06-14 10:46 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Corbin CLA 2004-07-08 20:08:14 EDT
Consider:
public class Foo {
  private int alpha;
  private void beta() { alpha++ };
  private vodi delta() { alpha-- };
}

If I try push "beta" down, and select "Add Required", it will include alpha and
remove it from the Foo class.  What it SHOULD so, is change alpha to protected.
 It should also look at protected methods/members that are used by other derived
classes and they should be excluded from the "required list".
Comment 1 Dirk Baeumer CLA 2004-07-17 14:06:23 EDT
An alernative would be to add delta to the list of required elements as well. 
Comment 2 David Corbin CLA 2004-07-17 16:05:39 EDT
I would consider it a bad alternative. 
Comment 3 Markus Keller CLA 2004-08-18 09:21:37 EDT
Third variant: Add an entry "Increase visibility" to the "Action" column and
choose this when the user pressed "Add Required" button.
Comment 4 David Corbin CLA 2004-08-18 14:33:35 EDT
Thats good.
Comment 5 Markus Keller CLA 2005-05-02 11:16:59 EDT
Moving to new owner. Not critical for 3.1.
Comment 6 Tobias Widmer CLA 2006-04-20 05:00:38 EDT
Not for 3.3
Comment 7 Martin Aeschlimann CLA 2007-02-16 04:01:04 EST
Not planed for 3.3