Bug 69657 - [dom] deprecate JLS2 once JLS3 is fully supported
Summary: [dom] deprecate JLS2 once JLS3 is fully supported
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.1 M6   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-08 14:49 EDT by Jim des Rivieres CLA
Modified: 2005-03-31 19:25 EST (History)
2 users (show)

See Also:

Attachments
Patch to deprecate JLS2 in DOM/AST (184.22 KB, patch)
2005-03-14 19:51 EST, Jim des Rivieres CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jim des Rivieres CLA 2004-07-08 14:49:05 EDT 
Once JLS3 APIs are fully operational in 3.1 stream:

(1) Deprecate all JLS2-related APIs.

Places in JDT Core are marked with TODOs like:

// TODO (jeem) When JLS3 support is complete (post 3.0) - deprecated Clients 
should port their code to use the new JLS3 API and call {@link #newAST(int)} 
instead of using this constructor.

(2) Remove notes on JDT Core API instructing people to avoid using JLS3.
E.g.
     * <p>
     * <b>NOTE:</b>In Eclipse 3.0, there is no underlying parser support for
     * JLS3 ASTs. This support is planned for the follow-on release of
     * Eclipse which includes support for J2SE 1.5. Without a parser to create
     * JLS3 ASTs, they are not much use. Use JLS2 ASTs instead.
     * </p>
Comment 1 Olivier Thomann CLA 2005-02-02 10:17:50 EST 
Jim, can we consider JLS3 as fully operational now?
Comment 2 Jim des Rivieres CLA 2005-02-24 18:08:31 EST 
Philippe,  Are we ready to do this?
Comment 3 Jim des Rivieres CLA 2005-03-14 19:51:37 EST 
Created attachment 18782 [details]
Patch to deprecate JLS2 in DOM/AST

Olivier, Please review and release this patch which deprecates the
JLS2-specific DOM/AST API and cleans up the specs.

Notes:
- All JLS2-only methods have been deprecated.
- I did *not* deprecate the various FOO_PROPERTY constants for JLS2 only
properties. This allows generic tools (like ASTRewrite) to use them
properties without getting deprecations warnings.
- All JLS3 constructs are now listed as @since 3.1 (even though most were
introduced in 3.0 in an early form). This is consistent with 3.1 being the
first release in which JLS3 is supported.
- I introduced various internal methods in DOM/AST to get rid of deprecations.
- SortElementBuild is the last remaining uses in JDT Core of JLS2. Someone
should look at porting it to JLS3.
Comment 4 Olivier Thomann CLA 2005-03-14 22:56:35 EST 
I will look at the SortElementBuilder in the same time I fix bug 81797 and bug
80036.
Comment 5 Olivier Thomann CLA 2005-03-16 14:53:25 EST 
Fixed and released in HEAD.
Comment 6 Olivier Thomann CLA 2005-03-31 19:25:04 EST 
Verified in  I20050331-1600