Bug 69336 - [change method signature] does not save the source
Summary: [change method signature] does not save the source
Status: NEW
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-06 02:31 EDT by Shraddha Bajaj CLA
Modified: 2022-10-04 14:18 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Shraddha Bajaj CLA 2004-07-06 02:31:10 EDT
if you refactor the method signature from the place of usage, it does not save 
the file where method is declared and therefore it gives compilation error in 
the place of usage.
Comment 1 Dirk Baeumer CLA 2004-07-06 05:57:05 EDT
Which build are you using ?
Do you having anything in the log file ?
Comment 2 Markus Keller CLA 2004-07-06 14:23:52 EDT
Cannot reproduce a problem with saving prior to change method signature execution.

However, there seems to be a timing problem with the reconciler. Steps in 3.0:

p/A.java:
package p;
public class A {
	void call () {
		new B().method(null);
	}
}

p/B.java:
package p;
public class B {
	void method(Object param) { }
}

- save both editors and split the editor pane such that both are visible
- select "method" in A.java and remove the parameter with Change Method Signature

=> Sometimes (but not always), there is a wrong error annotation in A.java
saying "The method method(Object) in the type B is not applicable for the
arguments ()". The error disappears as soon as a key is pressed in the editor.

I could also reproduce this problem by doing Refactor > Undo/Redo via keyboard
with varying waiting periods between successive invocations.

Moving to JDT/text.
Comment 3 Dani Megert CLA 2004-07-07 05:41:26 EDT
Filed bug 69449 for the problem reported in comment 2.
This bug is about not saving the method at all.
Comment 4 Eclipse Genie CLA 2020-07-14 17:44:49 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 5 Eclipse Genie CLA 2022-10-04 14:18:50 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.