Bug 6931 - working set removed on cancel
Summary: working set removed on cancel
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-12-14 06:24 EST by Martin Aeschlimann CLA
Modified: 2001-12-17 11:44 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2001-12-14 06:24:38 EST
1. In the package view open the working set selection dialog
2. remove an existing entry
3. press cancel
4. open the dialog again. entry was removed, even cancel was pressed.
Comment 1 Dani Megert CLA 2001-12-14 06:49:46 EST
This is a SELECTION dialog. Cancel means the same as in all other selection
dialogs: don't select and close - it does not effect other actions.

To be more user friendly, the list also allows you to modify, create and remove
working sets from the workspace (otherwise this would have to be done via
Workbench -> Preferences).

I could add a confirmation dialog, but normally I hate that.

BTW: this is the same behavior as in VAJ *and* Leapfrog

Suggest no further action.
Comment 2 Martin Aeschlimann CLA 2001-12-17 08:20:56 EST
as this is a selection dialog I agree.
problem is that 'remove' also makes sense in another context: Disabling the 
working set from the package view.
I wanted to deselect the working set. I did not think enough and pressed 
remove. Then I saw that this deleted my valuable working set and I canceled. 

in my opinion, the working set dialogs are currently confusing.  



Comment 3 Dani Megert CLA 2001-12-17 08:49:06 EST
There is
- an explicit "Remove filter..." on the Packages view.
- a dialog title which gives the context for the remove "Working Sets"

I could allow to unselect the current selection and then allow to press ok,
would that help?
Comment 4 Dani Megert CLA 2001-12-17 11:44:23 EST
Changed working set selection dialog, packages view and search dialog to allow
empty selection.

Closing this PR. New bug should be reported against upcoming working set
solution from platform (this is a commited item on the 2.0 plan).
Available in builds > 20011217