Bug 6891 - Enclosing type checkbox doesn't appear in tab order in new class wizard
Summary: Enclosing type checkbox doesn't appear in tab order in new class wizard
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: Other other
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Claude Knaus CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-12-13 09:24 EST by Nick Edgar CLA
Modified: 2001-12-17 08:46 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2001-12-13 09:24:11 EST
Build 20011211

In the new class wizard, the checkbox for enclosing type doesn't appear in the 
tab order.  The JDT code doesn't seem to be doing any magic.
Comment 1 Steve Northover CLA 2001-12-13 15:46:21 EST
It's actually working.  The first traversable widget in the tree is the 
checkbox.  To see this, tab all the way to the Cancel button and hit one more 
tab.  Focus goes to the checkbox.

So, here's what's happening.  The rule is that tab groups are traversed in the 
order that they are created, typically using the tab keys.  When a tab group 
contains another tab group, focus is given first to the default tab group and 
then the other tab groups.  The default tab group consists of all non-tab group 
widgets (such as check and radio buttons) that are not enclosed in another tab 
group.  Non-tab item widgets are typically traversed using the arrow keys.

This algorithm, while leading to some confusion for the developer, ensures that 
every widget will be traversable.

MCQ, do you want to reword this and add it to the SWT JavaDoc?
Comment 2 Nick Edgar CLA 2001-12-14 09:25:25 EST
I believe the wizard creates the controls top-down.
Are you saying they need to enclose the checkbox in another composite so that 
it creates a new tab group?
Please advise on how JDT should change their code (NewClassCreationWizardPage).
Comment 3 Steve Northover CLA 2001-12-14 10:40:54 EST
Yes, enclose it in a composite (a composite is a tab group), then there will no 
longer be a "default tab group" and traversal will work the way you expect.
Comment 4 Steve Northover CLA 2001-12-14 10:43:06 EST
JTD should try the new composite work around.
Comment 5 Erich Gamma CLA 2001-12-14 12:15:57 EST
claude can you pls give it try
Comment 6 Claude Knaus CLA 2001-12-17 06:36:42 EST
The workaround would work. However, I'm getting contradictory information about
what the behaviour should be for default tab group.
Either the default tab group elements are traversed inorder (interleaved) with
the other tab groups in the oder of creation, or they are traversed first
(that's what seems to be happening now).
What is the reasoning for having this default tab group to be visited first?
Comment 7 Mike Wilson CLA 2001-12-17 08:42:05 EST
Added SN to CC list so he can answer the question.
Comment 8 Claude Knaus CLA 2001-12-17 08:46:03 EST
fixed > 20011214