Bug 68048 - [log] Better handling of errors on state build
Summary: [log] Better handling of errors on state build
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.2 RC3   Edit
Assignee: Pascal Rapicault CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
: 60002 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-06-21 13:53 EDT by Pascal Rapicault CLA
Modified: 2006-05-05 06:41 EDT (History)
4 users (show)

See Also:

Attachments
Patch for BuildTimeSite (3.90 KB, patch)
2006-05-04 15:40 EDT, Pascal Rapicault CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2004-06-21 13:53:32 EDT 
If something goes wrong while building the state (for example a bogus version
number or a typo in the manifest), the build fails and some exceptions are log.

However this is not great because nothing is clearly indicated to the user
regarding the plugin that caused the failure. See for example bug #68047.
Comment 1 Pascal Rapicault CLA 2005-05-19 17:33:10 EDT 
*** Bug 60002 has been marked as a duplicate of this bug. ***
Comment 2 Pascal Rapicault CLA 2005-11-10 11:00:48 EST 
The OSGi resolver has now a better API to report problems.
We need to leverage this.

Note that PDE UI claims that it now uses this API. We may want to rip the code
from them.

The PDE Build code doing error reporting is in PDEState.getRegistry().
Comment 3 Pascal Rapicault CLA 2005-11-10 11:34:26 EST 
I meant BuildTimeSite.getRegistry()
Comment 4 Jeff McAffer CLA 2006-04-09 22:18:49 EDT 
+1 for 3.2 assuming the risk level is relatively low.  Better logging in PDE builds are high value.  Marking this as a polish item.
Comment 5 Pascal Rapicault CLA 2006-05-04 15:40:44 EDT 
Created attachment 40415 [details]
Patch for BuildTimeSite
Comment 6 Pascal Rapicault CLA 2006-05-04 15:41:33 EDT 
Andrew, Jeff could you please review and give your +1.
Comment 7 Andrew Niefer CLA 2006-05-04 17:06:01 EDT 
+1
Comment 8 Jeff McAffer CLA 2006-05-04 21:31:32 EDT 
+1
Comment 9 Wassim Melhem CLA 2006-05-04 22:44:42 EDT 
This one would certainly be high-value.

+1
Comment 10 Pascal Rapicault CLA 2006-05-05 06:41:50 EDT 
Released for RC3.