Bug 67717 - NPE disassembling .class file
Summary: NPE disassembling .class file
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 RC3   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-17 16:46 EDT by Olivier Thomann CLA
Modified: 2004-06-18 12:02 EDT (History)
0 users

See Also:

Attachments
Apply on HEAD (809 bytes, patch)
2004-06-17 16:48 EDT, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2004-06-17 16:46:36 EDT 
Using latest, I got a NPE disassembling the class:

xml.jar org/apache/xerces/impl/dtd/DTDGrammar.class

The bug is due to a missing break in the DefaultBytecodeVisitor. The fix is
trivial and low risk. I will attach a patch.
Comment 1 Olivier Thomann CLA 2004-06-17 16:48:24 EDT 
Created attachment 12428 [details]
Apply on HEAD
Comment 2 Philipe Mulet CLA 2004-06-17 17:42:21 EDT 
Regression from 2.1, fix is trivial.
+1
Comment 3 Olivier Thomann CLA 2004-06-17 17:43:07 EDT 
This is a regression from 2.1. This comes disassembling the .class file
generated by JDK1.5. The constant class has been added in the switch statement,
but the break; statement is missing to prevent the String case to fall through
the ConstantClass case. This is trivial, low risk and make the
DefaultBytecodeVisitor working fine.
Comment 4 Darin Wright CLA 2004-06-17 17:44:12 EDT 
+1 for RC3
Comment 5 Olivier Thomann CLA 2004-06-17 17:56:10 EDT 
Fixed and released in HEAD
Comment 6 Olivier Thomann CLA 2004-06-18 12:02:47 EDT 
Verified in 200406180800