Bug 66192 - Polish patch: support view activation via a keyboard shortcut
Summary: Polish patch: support view activation via a keyboard shortcut
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 RC2   Edit
Assignee: Darin Swanson CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2004-06-08 14:07 EDT by Markus Keller CLA
Modified: 2004-06-10 03:04 EDT (History)
0 users

See Also:

Attachments
Patch (2.44 KB, patch)
2004-06-08 14:07 EDT, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2004-06-08 14:07:05 EDT 
I'll add a patch for the jdt.debug plugin which makes all views accessible via
keyboard shortcut.

It registers the views in the brand-new 'Views' category of the Keys preferences
page, where users can assign a shortcut to directly jump to the view.

See bug 62243 for more info. Thanks.
Comment 1 Markus Keller CLA 2004-06-08 14:07:35 EDT 
Created attachment 11749 [details]
Patch
Comment 2 Kevin Barnes CLA 2004-06-08 17:04:50 EDT 
applied patches.
Comment 3 Kevin Barnes CLA 2004-06-08 17:05:16 EDT 
DarinS, please verify
Comment 4 Darin Swanson CLA 2004-06-08 18:57:25 EDT 
Why does the display view command show up with the fully qualified name of the 
view? It would appear to be to distinquish it from the Display command for the 
action of displaying...but it does look strange.

Verified.
Comment 5 Markus Keller CLA 2004-06-09 02:57:30 EDT 
I agree that it looks a bit strange. I also guessed it's because there is also a 
  Category: Run/Debug
  Command: Display (org.eclipse.jdt.debug.ui.commands.Display)
.

If these two commands would not include the command id, they would not be
distingushable in the 'Assignments' table of the 'Key Sequence' group. E.g.
entering Ctrl+Shift+D in the 'Key Seqence > Name' would not reveal which command
is bound.

If it really hurts you, please file a bug against Platform/UI, or change one of
the command names. (Note that the problem is really with the English language,
which uses the same word for the command verb 'display' and the noun 'display' ;-).
Comment 6 Markus Keller CLA 2004-06-10 03:04:33 EDT 
I've entered bug 66462 for the rendering of command ids in the case of duplicate
command names.