Bug 65943 - Closing/opening a project doesn't have the correct delta
Summary: Closing/opening a project doesn't have the correct delta
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 M1   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 64887
  Show dependency tree
 
Reported: 2004-06-07 07:18 EDT by Jerome Lanneluc CLA
Modified: 2004-08-25 11:54 EDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (3.67 KB, patch)
2004-06-07 07:20 EDT, Jerome Lanneluc CLA 		no flags Details | Diff
Updated tests (1.83 KB, patch)
2004-06-07 07:20 EDT, Jerome Lanneluc CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2004-06-07 07:18:21 EDT 
I20040529

Closing a project shows the following Java delta:
Java Model[*]: {CHILDREN | CONTENT}
   Test[-]: {}
   ResourceDelta(/Test)[*]

It should show:
Java Model[*]: {CHILDREN | CONTENT}
   Test[*]: {CLOSED}
   ResourceDelta(/Test)[*]

The F_CLOSED flag is not set.
Same problem for the F_OPENED flag.
Comment 1 Jerome Lanneluc CLA 2004-06-07 07:18:43 EDT 
Problem was identified investigating bug 64887 which is targeted at 3.0 RC2.
Comment 2 Jerome Lanneluc CLA 2004-06-07 07:20:10 EDT 
Created attachment 11649 [details]
Proposed patch

Changed DeltaProcessor to create a CHANGED delta with F_CLOSED/F_OPENED flag
set if the project is closed/opened. Changed TypeHierarchy delta processing to
handle this flag.
Comment 3 Jerome Lanneluc CLA 2004-06-07 07:20:40 EDT 
Created attachment 11650 [details]
Updated tests

Changed JavaElementDeltaTests and JavaProjectTests to reflect this change.
Comment 4 Jerome Lanneluc CLA 2004-06-07 13:17:09 EDT 
Philippe should this be fixed for 3.0, or 3.1 ?
Comment 5 Philipe Mulet CLA 2004-06-07 15:43:27 EDT 
I think it is late in the game to perform such a change. We have been living 
with the bug since 2.0, and thus should stick to this behavior for 3.0, until 
we understand ramifications for our client (package explorer seems ok, but 
what about others?). 

Should release early post 3.0.
Comment 6 Jerome Lanneluc CLA 2004-07-01 10:35:15 EDT 
Reopening for inclusion in 3.1
Comment 7 Philipe Mulet CLA 2004-07-01 10:39:08 EDT 
Could be backported to 3.0.1 (unsure yet)
Comment 8 Jerome Lanneluc CLA 2004-07-01 12:53:18 EDT 
Released fix and tests in R3_0_maintenance and HEAD.
Comment 9 Dirk Baeumer CLA 2004-08-25 11:05:55 EDT 
The fact that this fix brokes the all types cache (see bug 72388) is IMO a 
clear indication that we shouldn't put the fix into the maintenance build. It 
might break other clients as well. So I opt to remove the fix from the 3.0.1 
stream. Comments ?
Comment 10 Jerome Lanneluc CLA 2004-08-25 11:22:58 EDT 
Will revert this change in R3_0_maintance only.
Comment 11 Jerome Lanneluc CLA 2004-08-25 11:54:36 EDT 
Change reverted in R3_0_maintenance only. Changing target milestone to 3.1 M1.