Bug 65748 - [type hierarchy] Hierarchy view fails to pick up class modifier change
Summary: [type hierarchy] Hierarchy view fails to pick up class modifier change
Status: CLOSED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.1 RC2   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-04 12:26 EDT by Tim Ellison CLA
Modified: 2005-06-10 05:45 EDT (History)
1 user (show)

See Also:

Attachments
Proposed fix (893 bytes, patch)
2005-05-27 11:58 EDT, Jerome Lanneluc CLA 		no flags Details | Diff
Regression test (1.95 KB, patch)
2005-05-27 11:59 EDT, Jerome Lanneluc CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Ellison CLA 2004-06-04 12:26:00 EDT 
3.0RC1

Open a public class in the hierarchy viewer, then in the editor change its 
modifier to default visibility and save changes.

Notice that the structure view updates to show the blue triangle decorator, but 
the hierarchy view of the same class is not updated.
Comment 1 Dirk Baeumer CLA 2004-06-05 11:18:04 EDT 
Not critical for 3.0
Comment 2 Tim Ellison CLA 2004-12-22 05:12:38 EST 
Problem still exists in 3.1M4
Comment 3 Martin Aeschlimann CLA 2005-05-20 10:10:23 EDT 
The problem is that (for performance reasons) we use cached flags offered by the
type hierarchy. Unless the type hirarchy is refreshed, the flags will be the same.
Either the type hierarchy gives a change notification whenever a modifier
changes, or we accept this bug and show the flags as they were when the
hierarchy was created.
The second take is ok for me. Moving to jdt.core to decide
Comment 4 Jerome Lanneluc CLA 2005-05-27 11:58:47 EDT 
Created attachment 21891 [details]
Proposed fix
Comment 5 Jerome Lanneluc CLA 2005-05-27 11:59:09 EDT 
Created attachment 21892 [details]
Regression test
Comment 6 Philipe Mulet CLA 2005-05-30 06:26:11 EDT 
+1 for RC2
Comment 7 Jerome Lanneluc CLA 2005-05-30 10:53:14 EDT 
Released fix and test.
Comment 8 Olivier Thomann CLA 2005-06-06 20:00:54 EDT 
Verified in N20050606-0010.
Comment 9 Frederic Fusier CLA 2005-06-10 05:45:05 EDT 
Verified for 3.1 RC2 using build I20050610-0010