Bug 65637 - [model] Excluded package still in Java model
Summary: [model] Excluded package still in Java model
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M5   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 65240
Blocks:
  Show dependency tree
 
Reported: 2004-06-03 17:12 EDT by Jerome Lanneluc CLA
Modified: 2006-02-14 07:37 EST (History)
1 user (show)

See Also:

Attachments
Proposed patch (2.10 KB, patch)
2004-06-03 17:37 EDT, Jerome Lanneluc CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2004-06-03 17:12:33 EDT 
I20040529

1. Create a Java project with the following structure:
proj
  src
    org
      eclipse
        mypack
          A.java
2. Set an exclusion filter of src to "org/*|org/eclipse/*".
Observe: Empty packages org and org.eclipse are still in Java model. Only 
org.eclipse.mypack should be in te Java model, and org should be a non-Java 
resource.
Comment 1 Jerome Lanneluc CLA 2004-06-03 17:15:01 EDT 
Note UI bug 65240 needs to be fixed first (Package explorer is broken in 
hierarchical layout mode if a package exists without its super package).
Comment 2 Jerome Lanneluc CLA 2004-06-03 17:16:07 EDT 
From a pure Java model point, we're inconsistent with the equivalent case of 
the "org/eclipse/mypack" inclusion filter.
Comment 3 Jerome Lanneluc CLA 2004-06-03 17:30:54 EDT 
To be precise, the 2 following patterns should be equivalent:
- "*|org/*|org/eclipse/*" exclusion pattern
- "org/eclipse/mypack/" inclusion pattern
Comment 4 Jerome Lanneluc CLA 2004-06-03 17:37:43 EDT 
Created attachment 11571 [details]
Proposed patch
Comment 5 Dirk Baeumer CLA 2004-06-04 04:16:53 EDT 
Fixing this will break the hierarchical layout mode in package explorer and 
packages view, so I request not fixing this for 3.0 since we can't adapt the 
views to this (see comments in bug 65240). 

For the UI it would even be better if the inclusion case would report parents 
as packages as well. However I can understand that this is wrong from a model 
standpoint so we decided to doc this UI issue as a know limitation for 3.0.
Comment 6 Frederic Fusier CLA 2004-06-21 09:21:48 EDT 
deferred post 3.0
Comment 7 Jerome Lanneluc CLA 2004-07-05 07:09:00 EDT 
Reopening for inclusion in 3.1. Dirk can the UI be now changed to support this 
scenario ?
Comment 8 Dirk Baeumer CLA 2004-07-08 06:39:57 EDT 
Yes, we have to change it for inclusion filters anyway. But this requires some 
work and it will very likely not be done in the next 2 - 3 months since we are 
focusing on 1.5. 

I make the bug dependend on bug 65240 since this should fix it for exclusion 
filters as well.
Comment 9 Jerome Lanneluc CLA 2005-05-12 06:10:55 EDT 
Since bug 65240 is not going to be fixed for 3.1, deferring this bug post 3.1.
Comment 10 Jerome Lanneluc CLA 2006-01-17 11:39:23 EST 
Reopening since bug 65240 is now fixed.
Comment 11 Jerome Lanneluc CLA 2006-01-26 05:04:23 EST 
Release patch and added regression test ExclusionPatternTests#testCreateExcludePackage2()
Comment 12 Frederic Fusier CLA 2006-02-14 07:37:10 EST 
Verified for 3.2 M5 using build I20060214-0010.