Bug 65174 - Spurious "Javadoc: Missing reference" error
Summary: Spurious "Javadoc: Missing reference" error
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.0 RC2   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-01 17:00 EDT by Avi Drissman CLA
Modified: 2004-06-11 09:04 EDT (History)
0 users

See Also:

Attachments
Fixes and tests for 65174, 65253, 65288 bugs (4.15 KB, application/octet-stream)
2004-06-03 12:01 EDT, Frederic Fusier CLA 		no flags Details
New fixes and tests for 65174, 65253, 65288 bugs (10.08 KB, application/octet-stream)
2004-06-04 08:00 EDT, Frederic Fusier CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Avi Drissman CLA 2004-06-01 17:00:18 EDT 
On code like:

/** Constructs a {@link FooTokenizer} filtered by a {@link
* BarFilter}, a {@link BazFilter}, and a {@link FlooFilter}. */
public final TokenStream tokenStream(String fieldName, Reader reader)
{ //...

turning the preference Java > Compiler > Javadoc > Malformed Javadoc comments to Warning causes a 
spurious "Missing reference" error on that second @link that's split between lines. Since the javadoc tool 
doesn't care, should Eclipse?

(On 3.0RC1)
Comment 1 Frederic Fusier CLA 2004-06-02 05:10:36 EDT 
It seems there's a problem due to the fact that splitted link tag is on first
line of javadoc comment. It does not occur with following comment:
/**
* Constructs a {@link FooTokenizer} filtered by a {@link
* BarFilter}, a {@link BazFilter}, and a {@link FlooFilter}. */
public final TokenStream tokenStream(String fieldName, Reader reader)
{ //...

I'll investigate...
Comment 2 Frederic Fusier CLA 2004-06-03 12:01:55 EDT 
Created attachment 11544 [details]
Fixes and tests for 65174, 65253, 65288 bugs

As fixes for these three bugs were in same method of AbstractCommentParsre, it
was easier to bundle them in only on patch file.

bug 65174: line end init value was incorrect. Instead of javadoc start
position, we had to initialize it with line end of javadoc start position.

bug 65253: remove test for java identifier start when '@' is encountered at
line start (introduced while fixing bug 51660). This wrongly let parser think
that it was always at start of line even after several '@' characters...

bug 65288: remove '*' as valid character for tag names. This made parser skip
end of comment in described test case.
Comment 3 Frederic Fusier CLA 2004-06-04 08:00:36 EDT 
Created attachment 11589 [details]
New fixes and tests for 65174, 65253, 65288 bugs

New fixes and tests due to some regressions in "massive" AST Javadoc tests with
previous one...

This one pass all tests:
- AllJDTCore
- JDT/UI: Automated + Refactoring
- Massive: ASTConverterJavadoc + DefaultCommentMapper

Note that all tests were run with patch for bug 65180
Comment 4 Frederic Fusier CLA 2004-06-08 13:32:04 EDT 
Fixed.

No error signaled now in this peculiar case.

[jdt-core-internal]
Changes done in AbstractCommentParser.
Also fix minor problem with line start which had a minor impact on some 
TextElement start position...
Test case added in JavadocTestMixed + ASTConverterJavadocTests
Comment 5 David Audel CLA 2004-06-11 09:04:48 EDT 
Verified for 3.0RC2