Bug 64347 - [key binding] cannot expand/collapse folded regions via keyboard
Summary: [key binding] cannot expand/collapse folded regions via keyboard
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 RC3   Edit
Assignee: Christof Marti CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2004-05-27 11:01 EDT by Randy Hudson CLA
Modified: 2004-06-18 11:24 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Randy Hudson CLA 2004-05-27 11:01:30 EDT 
The user cannot expand or collapse folded regions without using the mouse.
Comment 1 Kai-Uwe Maetzel CLA 2004-05-27 11:56:12 EDT 
See assigned key bindings.
Comment 2 Randy Hudson CLA 2004-05-27 12:05:57 EDT 
The keybinding should be organized under "Source Editing", not the 
general "Edit" category.

Also, the default binding requires an external keyboard. Notebook users will 
not find this keybinding. Even desktop users will not find it because it is not 
intuitive that MINUS be treated differently just because it is on the 
numberpad. Can we change to CTRL+- and CTRL+EQUALS? These are commonly used for 
zoom in/out.
Comment 3 Kai-Uwe Maetzel CLA 2004-06-16 11:51:47 EDT 
Adding Dirk for second vote on changing the category for the key bindings.
Comment 4 Kai-Uwe Maetzel CLA 2004-06-16 13:58:12 EDT 
Approved by Dirk & Kai.
Comment 5 Christof Marti CLA 2004-06-17 11:55:25 EDT 
Fixed in builds >20040617
Comment 6 Markus Keller CLA 2004-06-18 08:43:38 EDT 
Verified in 200406180010 that all 4 folding commands (Collapse, Expand, Expand
All, Toggle Folding) are in the 'Text Editing' category.

Randy, I guess you'll have to open a separate PR for changing default
keybindings. However, I don't think CTRL+- and CTRL+EQUALS would be well
supported by the current keybinding architecture. E.g. I can't press CTRL+EQUALS
on a Swiss German keyboard, because EQUALS (=) is Shift+0 on that keyboard
layout, and CTRL+Shift+0 does not run a command assigned to CTRL+EQUALS.
Comment 7 Randy Hudson CLA 2004-06-18 11:24:05 EDT 
Couldn't a regional override be used in that case?  There are probably more 
laptop users than users with Swiss German keyboards.

We use CTRL+= in GEF and no one mentioned this issue yet.