Bug 63438 - ManifestConsistencyChecker.validJava is expensive
Summary: ManifestConsistencyChecker.validJava is expensive
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 RC1   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2004-05-21 11:44 EDT by Kent Johnson CLA
Modified: 2004-05-28 01:53 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Johnson CLA 2004-05-21 11:44:35 EDT 
20040519

The method ManifestConsistencyChecker.validJava is populating the JavaModel 
with numerous findType() calls & is causing significant memory growth... ~3Mb 
on a full build of eclipse.

The method has 3 separate places in which it calls findType & 2 of them look 
to be no-ops & can be removed trivially.
Comment 1 Kent Johnson CLA 2004-05-21 12:08:38 EDT 
The first call should be replaced with an index query instead of a JavaModel 
cache lookup... see SearchEngine.searchAllTypeNames().
Comment 2 Wassim Melhem CLA 2004-05-28 01:53:32 EDT 
Fixed as per Kent's suggestion.