Bug 6299 - JavaWorkbenchAdapter does not provide images
Summary: JavaWorkbenchAdapter does not provide images
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Dirk Baeumer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-11-26 05:05 EST by David Peroutka CLA
Modified: 2002-01-30 09:47 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Peroutka CLA 2001-11-26 05:05:46 EST 
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns
null; not very nice when presenting in a viewer.

Solution (just suggestion;):

org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor

...
org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider;
...
return imageProvider.getImageDescriptor((IJavaElement)element,
JavaElementImageProvider.SMALL_ICONS);
Comment 1 Dirk Baeumer CLA 2002-01-10 04:28:59 EST 
Good suggestion.

Should investigate if this breaks existing code. If not, we should return an 
image descriptor and not null.
Comment 2 Dirk Baeumer CLA 2002-01-30 09:47:42 EST 
Fixed in build > 20020129