Bug 62812 - Some malformed javadoc tags are not reported as malformed
Summary: Some malformed javadoc tags are not reported as malformed
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 RC1   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-18 17:29 EDT by Olivier Thomann CLA
Modified: 2004-05-28 15:08 EDT (History)
0 users

See Also:

Attachments
Test case (441 bytes, application/octet-stream)
2004-05-18 21:22 EDT, Olivier Thomann CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2004-05-18 17:29:03 EDT 
Using 0518_0816, some malformed inline javadoc tags are not reported as malformed.

For example:
@{link #foo())} is not reported as malformed, but the javadoc tool reports it as
malformed. Removing the extra closing parenthesis fixes it.
Comment 1 Olivier Thomann CLA 2004-05-18 21:22:22 EDT 
Created attachment 10816 [details]
Test case

This doesn't report any error even with malformed javadoc comment reported as
error.
Comment 2 Olivier Thomann CLA 2004-05-18 21:22:57 EDT 
The javadoc tool reports:
c:\eclipse\workspaces\test0518\P\src\p\B.java:8: warning - Tag @link: malformed:
"A#bar())"
c:\eclipse\workspaces\test0518\P\src\p\B.java:8: warning - Tag @link: malformed:
"A#bar())"
c:\eclipse\workspaces\test0518\P\src\p\B.java:8: warning - Tag @link: reference
not found: A#bar())
c:\eclipse\workspaces\test0518\P\src\p\B.java:8: warning - Tag @link: malformed:
"A#bar())"
c:\eclipse\workspaces\test0518\P\src\p\B.java:8: warning - Tag @link: malformed:
"A#bar())"
c:\eclipse\workspaces\test0518\P\src\p\B.java:8: warning - Tag @link: reference
not found: A#bar())
c:\eclipse\workspaces\test0518\P\src\p\B.java:8: warning - Tag @link: malformed:
"A#bar())"
Comment 3 Olivier Thomann CLA 2004-05-18 21:23:40 EDT 
Removing the extra ) fixes the problem.
Comment 4 Frederic Fusier CLA 2004-05-24 11:19:12 EDT 
Fixed.

Now method references with no separation (ie. white space) after the argument
declaration closing brace are considered as malformed and warned with following
new Javadoc message:
Javadoc: Malformed reference (missing separator after method reference closing
brace)

[jdt-core-internal]
Changes done in:
1- AbstractCommentParser.parseArguments(Object): when closing brace is
encountered and valid in arguments syntax, then verify that current character is
a white space,
2- ProblemReporter, IProblem and message.properties: Add new message

Test case added in JavadocTestMixed
Comment 5 Olivier Thomann CLA 2004-05-28 15:08:23 EDT 
Verified in 200405281200