Bug 62733 - Borders missing on toolbar buttons
Summary: Borders missing on toolbar buttons
Status: RESOLVED WORKSFORME
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Dejan Glozic CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2004-05-18 14:27 EDT by Randy Hudson CLA
Modified: 2009-06-08 10:54 EDT (History)
1 user (show)

See Also:


Attachments
missing topleft and bottomright borders (2.91 KB, image/gif)
2004-05-18 14:27 EDT, Randy Hudson CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Randy Hudson CLA 2004-05-18 14:27:33 EDT
The use of native toolbars with white backgrounds leads to invisible borders.
Comment 1 Randy Hudson CLA 2004-05-18 14:27:55 EDT
Created attachment 10784 [details]
missing topleft and bottomright borders
Comment 2 Dejan Glozic CLA 2004-05-18 15:28:40 EDT
I agree that this is leads to a less fortunate result, but it still works. 
Win2K is not a reference Windows platform - Windows XP is. This looks much 
better on XP.
Comment 3 Randy Hudson CLA 2004-05-18 15:44:13 EDT
Actually, I'm using Windows XP.  It also looks bad on other platforms.
Comment 4 Dejan Glozic CLA 2004-05-18 15:58:01 EDT
Then you are not using manifest file to tell SWT to pick up skinned (XP) 
widgets.

Will look at the other platforms.
Comment 5 Randy Hudson CLA 2004-05-18 16:28:49 EDT
Wrong again. I do not have skins enabled because it is too ugly.
BTW, most users do not have this file present, so why would you design your UI 
around the 2% case?
Comment 6 Dejan Glozic CLA 2004-05-18 18:17:55 EDT
Randy, most native XP application have skinned widgets. In addition, Eclipse-
based products (not Eclipse SDK) do not count on finding JRE installed on the 
target machine - they install the JRE of the make and model they tested the 
product with. Therefore, they have the opportunity to ship with the manifest 
file. This brings the percentage to much more than 2%.

Regardless, I don't think the screenshot you sent me is too bad. The buttons 
already have hand cursor (thus reinforcing the hyperlink metaphor) so even if 
half of the border is missing, there is enough visual affordances to make it 
clear that the area is clickable. 'Sticky' button (SWT.CHECK style) is 
visually unambiguous. It may not be completely polished but it is not tragic. 
The alternative is reimplementing it as custom code - not worth the effort at 
the moment.
Comment 7 Dejan Glozic CLA 2004-05-18 18:19:30 EDT
My first sentence was not clear enough: when I said 'most native XP 
applications have skinned widgets' my point was that arguing that they are too 
ugly is futile - all MS applications use these widgets, and so shall we if we 
want to feel like a native app.
Comment 8 Randy Hudson CLA 2004-05-18 18:45:02 EDT
Dejan, I have the .manifest file on my machine.  None of my windows application 
have skins because I have turned off the XP skins by opening the Display 
Properties Dialog from the control panel, and choosing the "Windows Classic" 
theme.  Many XP users do this because the "classic" L&F runs faster and 
consumer less battery power.

I have the JRE which will be distributed with the next release of WSAD.  There 
is no .manifest file in it.

Microsoft Office does not use the native toolbar.  They ship their own emulated 
one instead.
Comment 9 Dejan Glozic CLA 2005-04-29 17:46:43 EDT
Will not be handled in 3.1
Comment 10 Curtis Windatt CLA 2009-06-08 10:54:03 EDT
Works in 3.5