Bug 62227 - Load Time Weaving aborts on any kind of warning (declare/xlint)
Summary: Load Time Weaving aborts on any kind of warning (declare/xlint)
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: 1.2   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Andrew Clement CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-14 05:34 EDT by Andrew Clement CLA
Modified: 2004-05-18 15:46 EDT (History)
0 users

See Also:


Attachments
Tescases for declare warning declare error (2.14 KB, application/octet-stream)
2004-05-14 07:01 EDT, Matthew Webster CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Clement CLA 2004-05-14 05:34:16 EDT
The message handler in the weaving adapter for load time weaving says:

public boolean handleMessage(IMessage message) throws AbortException {
  if (!isIgnoring(message.getKind())) {
    if (verbose) System.err.println(message.getMessage());
    throw new AbortException(message);
  }
  return true;
}

This means for warnings it goes bang.  So, even a declare warning that is 
meant to tell the user something informational during a LTW will cause the 
code to blow up.  The fix is straightforward and simply to log warning 
messages and only fail for error messages.  I am waiting for a testcase from 
Matthew before checking in the fix.
Comment 1 Matthew Webster CLA 2004-05-14 07:01:17 EDT
Created attachment 10642 [details]
Tescases for declare warning declare error

Please run the modified BcweaverJarMaker for running BcweaverModuleTests. There
should be one failure for declare warning
Comment 2 Andrew Clement CLA 2004-05-18 15:46:59 EDT
fix and testcases checked in.