Bug 61214 - The classpath computation inside the Java builder should get rid of duplicates entries
Summary: The classpath computation inside the Java builder should get rid of duplicate...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M9   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-06 10:25 EDT by Olivier Thomann CLA
Modified: 2004-05-18 13:05 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2004-05-06 10:25:38 EDT 
Using 200405060200 and trying to investigate bug 61097, I noticed that the name
environment used by the java builder can contain more than once the same entry.
This can have an impact on the performance of the Java builder.

Steps to reproduce:
1) Start a self-hosting workspace
2) Import JDT/Core and the JDT/Core tests projects from CVS
3) Change the JDT/Core plugin.xml to reexport the required projects
4) Put a breakpoint in org.eclipse.jdt.internal.core.builder.NameEnvironment
line 91.
5) Go to the one of the JDT/Core tests projects and add a space in its
plugin.xml file.

6) The breakpoint will ne hit and you can inspect the classpathEntries variable.
You can notice that it contains two occurences of org.eclipse.core.resources.
One is exported and one is not exported. This should be filtered out. The java
builder needs only one of them.
Comment 1 Olivier Thomann CLA 2004-05-06 17:18:45 EDT 
Fixed and released in HEAD.
Regression test added in ClasspathTest (testRemoveDuplicates).
Comment 2 David Audel CLA 2004-05-18 13:05:49 EDT 
Verified for 3.0M9