Bug 58794 - Inexact matches reported for javadoc matches in plugin jars
Summary: Inexact matches reported for javadoc matches in plugin jars
Status: RESOLVED INVALID
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M9   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-16 04:43 EDT by Thomas M??der CLA
Modified: 2004-04-20 14:14 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas M??der CLA 2004-04-16 04:43:42 EDT
I2004-04-13

1) check out org.eclipse.jdt.ui as source (in a new workspace). The PDE
classpath container should magically add all the necessary dependencies
2) open JavaProjectionModelUpdater.dispose() and do a references in workspace
search (via the context menu) 
3) observe: you get 5 matches.

One of the matches is in
org.eclipse.debug.internal.ui.DelegatingModelPresentation; it looks like this:
<br>
<pre>
	/**
	 * Delegate to all extensions.
	 *
	 * @see IBaseLabelProvider#dispose()
	 */
	public void dispose() {
		Iterator i= getLabelProviders().values().iterator();
</pre>

The match is reported against the "@see" tag. Note the "IBaseLabelProvider" in
front of the "@see" tag.
Comment 1 Thomas M??der CLA 2004-04-16 04:44:16 EDT
My expectation would be to not get that match reported at all.
Comment 2 Philipe Mulet CLA 2004-04-16 06:29:22 EDT
I suspect IBaseLabelProvider couldn't be resolved, but you did not reveal 
Javadoc malformed tags, did you ?

Technically, it would be a true inaccurate match.
Need to double check though.
Comment 3 Frederic Fusier CLA 2004-04-19 05:51:40 EDT
Thomas,
I've checked out jdt-ui of last integration build (version v20040413a) and 
cannot find the class JavaProjectionModelUpdater!?
So, it's a little bit difficult to reproduce this problem...
Comment 4 Thomas M??der CLA 2004-04-19 05:55:56 EDT
You need jdt ui in source (i.e. HEAD).
Comment 5 Frederic Fusier CLA 2004-04-19 06:14:33 EDT
OK, I thought it this version was enough as your build reference was
I2004-04-13...
Comment 6 Frederic Fusier CLA 2004-04-20 14:14:22 EDT
Hummm... several things here...

1) PDE does not add magically necessary dependencies
Doing the same sceanrio but with all required plugins as binary in my 
workspace, I have not the same result:
the match in DelegatingModelPresentation is not longer found...

2) Even with all required plugins in workspace, there's still some inexact 
matches found in Javadoc...
Looking at found matches (LazyModelPresentation for example), the reference
to dispose() is in a Javadoc:
	/**
	 * @see IBaseLabelProvider#dispose()
	 */

but IBaseLabelProvider is not resolved in as there's no corresponding import...
So, these matches are true inaccurate matches...

For initial reported problem in DelegatingModelPresentation, as soon as 
references are correctly resolved by PDE, the error disappears because there's 
a magic import line which solves it:
import org.eclipse.jface.viewers.IBaseLabelProvider;