Bug 582447 - register number related to PC is incorrect for aarch64
Summary: register number related to PC is incorrect for aarch64
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Agent (show other bugs)
Version: 1.7   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Eugene Tarassov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-21 04:42 EDT by yuan bian CLA
Modified: 2023-09-23 12:16 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yuan bian CLA 2023-09-21 04:42:49 EDT 
In my opinion, dwarf_id or eh_frame_id defined in RegisterDefinition is equal to dwarf register number. 

For aarch64, you can see below tcf source code in which current dwarf_id related to PC is 33.
https://git.eclipse.org/c/tcf/org.eclipse.tcf.agent.git/tree/agent/machine/a64/tcf/cpudefs-mdep.c#n45

But you can see that it is defined as 32 in official aarch64 document as below.
https://github.com/ARM-software/abi-aa/blob/844a79fd4c77252a11342709e3b27b2c9f590cf1/aadwarf64/aadwarf64.rst

BTW, GDB also define register number with 32 for aarch64 PC register.

Can you help to check it?

Thanks.
Comment 1 Eugene Tarassov CLA 2023-09-23 12:16:39 EDT 
Yes, it should be 32.
I have committed a fix.
Note that TCF repositories are moved to Eclipse GitLab:
https://gitlab.eclipse.org/eclipse/tcf/tcf.agent

Thanks!