Bug 581434 - HPROF GZIP tests
Summary: HPROF GZIP tests
Status: VERIFIED FIXED
Alias: None
Product: MAT
Classification: Tools
Component: Core (show other bugs)
Version: 1.13   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.14.0   Edit
Assignee: Andrew Johnson CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2023-01-28 11:16 EST by Andrew Johnson CLA
Modified: 2023-03-20 04:40 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Johnson CLA 2023-01-28 11:16:50 EST 
The random access GZIP code is complex and could do with more tests.
The tests showed a minor error where mark() then skip() in an InflaterInputStream could fail to reset().
Comment 1 Eclipse Genie CLA 2023-01-28 11:21:28 EST 
New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/199618
Comment 3 Eclipse Genie CLA 2023-01-28 12:41:20 EST 
New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/199619
Comment 5 Eclipse Genie CLA 2023-01-28 13:41:38 EST 
New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/199620
Comment 7 Eclipse Genie CLA 2023-01-28 14:45:57 EST 
New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/199621
Comment 9 Eclipse Genie CLA 2023-01-28 16:16:19 EST 
New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/199622
Comment 11 Andrew Johnson CLA 2023-01-28 17:00:42 EST 
I then got build failures:

[INFO] --- tycho-p2-director-plugin:2.1.0:materialize-products (materialize-products) @ org.eclipse.mat.product ---
[INFO] Installing product org.eclipse.mat.ui.rcp.MemoryAnalyzer for environment win32/win32/x86_64 to /home/jenkins/agent/workspace/tycho-mat-nightly/org.eclipse.mat.product/target/products/org.eclipse.mat.ui.rcp.MemoryAnalyzer/win32/win32/x86_64/mat
Installing org.eclipse.mat.ui.rcp.MemoryAnalyzer 1.13.0.202301281742.
Installing org.eclipse.mat.ui.rcp.feature.feature.group 1.13.0.202301281742.
Installation failed.
An error occurred during the org.eclipse.equinox.internal.p2.engine.phases.CheckTrust phase.
	session context was:(profile=DefaultProfile, phase=org.eclipse.equinox.internal.p2.engine.phases.CheckTrust, operand=, action=).
	Error with signed content.
	Caused by: 
	java.security.NoSuchAlgorithmException: An error occurred while processing the signatures for the file: /home/jenkins/agent/workspace/tycho-mat-nightly/org.eclipse.mat.product/target/products/org.eclipse.mat.ui.rcp.MemoryAnalyzer/win32/win32/x86_64/mat/plugins/org.eclipse.mat.api_1.13.0.202301281742.jar
	Caused by: 
	java.security.NoSuchAlgorithmException: No algorithm found for 1.2.840.113549.1.1.12
There were errors. See log file: /tmp/tycho11509153289031945325equinox/config/1674927789898.log

which lead me to bug 572034
This suggested that a later Tycho is needed, at least 2.4.0
I upgraded to Tycho 2.75 and the build succeeded.
Comment 12 Eclipse Genie CLA 2023-01-29 04:39:59 EST 
New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/199625
Comment 14 Andrew Johnson CLA 2023-02-03 11:57:39 EST 
The tests cover 73% of InflaterInputStream.java and 66% of GZIPInputStream2.java

The snapshot tests will cover more.
Comment 15 Andrew Johnson CLA 2023-03-20 04:40:52 EDT 
Tests now run and pass in the CI build:
https://ci.eclipse.org/mat/job/tycho-mat-nightly/1384/testReport/org.eclipse.mat.tests.parser/GzipTests/